Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pin Tabs (sort) - Configure Map Tracks #16663

Open
Rowin63 opened this issue Mar 11, 2023 · 46 comments
Open

Allow to pin Tabs (sort) - Configure Map Tracks #16663

Rowin63 opened this issue Mar 11, 2023 · 46 comments
Labels

Comments

@Rowin63
Copy link

Rowin63 commented Mar 11, 2023

Description

The tabs in the new "configure map / tracks"-menu are not in alphabetical order, but have been before.

Steps to reproduce

Actual result

Expected result

Your Environment

OsmAnd Version: 4.4.0#14226
Android/iOS version:
Device model:

@Zirochkabila
Copy link
Collaborator

@Rowin63 You can sort them in any order you want

@Rowin63
Copy link
Author

Rowin63 commented Mar 11, 2023

Yes, the tracks. But I'm talking about the tabs (folders)

@Zirochkabila
Copy link
Collaborator

I agree
Perhaps we should add a tab sorting function (something similar to how it is implemented with tracks)

@Zirochkabila Zirochkabila reopened this Mar 11, 2023
@Zirochkabila Zirochkabila added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Mar 11, 2023
@Rowin63
Copy link
Author

Rowin63 commented Mar 11, 2023

It was in alphabetic order in the beginning

@sonora
Copy link
Member

sonora commented Mar 11, 2023

If @Rowin63 is right, I would consider this an issue. But actually, so far on my devices I can't reproduce. But the screen crashes under some circumstances, so maybe I cannot get to the situation to reproduce (#14890 (comment))...

@Rowin63
Copy link
Author

Rowin63 commented Mar 11, 2023

In 4.4.1 tabs are alphabetical.
In 4.4.0#14230 and the one before tabs are not alphabetical anymore (neither the overview page nor the tabs themselves)

@sonora
Copy link
Member

sonora commented Mar 11, 2023

Build 14230 is newer, so I'd say this is an Issue, well spotted!

In particular also because of the following situation: If you have your GPX tracks organized in subfolders like <osmand-data-folder>/tracks/Skitours/Variants, our legacy tracks screen under MyPlaces displays these folders as

  • Skitours
  • Skitours/Variants

but this new screen (both in its folder ribbon and on the "Switch folder" dialog) just displays

  • Skitours
  • Variants

i.e. suppresses any connection to the folder hierarchy. You cannot see which parent folder the "Variants" belong to (you may have several Variants folders belonging to different parents), unless the sorting is such that the parent is reliably the folder displayed immediately above / to the left.

@dmpr0 dmpr0 self-assigned this Mar 11, 2023
@sonora
Copy link
Member

sonora commented Mar 11, 2023

PS: @Zirochkabila , @dmpr0 Not sure we need a "Folder sorting o ption", I guess we would overkill things by far with non-essential functionality and complications, while we still miss a lot of essential functionality, like being able to search for tracks, view where a specific track is on the map, fix the crashes, etc., see #14890 and #16508.

@Rowin63
Copy link
Author

Rowin63 commented Mar 11, 2023

Its nice and helpful sorting the tracks, but no need for the folders.
But please keep them in alphabetical order. Thanks!

@sonora
Copy link
Member

sonora commented Mar 12, 2023

@Rowin63 Can you please check the folder sorting with the brand new builds to see if you still have the issue? We had some fixes in the sorting code and with successive builds I (still) cannot reproduce.

@Rowin63
Copy link
Author

Rowin63 commented Mar 12, 2023

Hello!

Actual +Version is 4.4.0#14233 from today.
Still I can not see an option for sorting the folders.
There is one option to change the folder (1)
And another option to change the appearance of the selected 0tracks (2)
But the folders still are mixed up.

Tracks Menu

@sonora
Copy link
Member

sonora commented Mar 12, 2023

Weird. Perhaps this was caused by some interim buggy build.

Do you have access to the tracks folder via some file manager app or a PC? It may be worth to exit OsmAnd, rename the folder to tracks0, restart OsmAnd, go to its tracks screen so OsmAnd realizes there now are zero tracks. Then kill OsmAnd again, rename tracks0 back (replacing the newly created, empty tracks folder). Does that fix it? Now it would be interesting if the issue comes back somehow. (and no, there is no folder sorting button).

@Rowin63
Copy link
Author

Rowin63 commented Mar 12, 2023

I did as you wrote.
After renaming my original track folder back to "tracks", the tabs/folders appear in exactly (!) the same mixed order like before! But their order is not by name and not by timestamp.

And folders are always alphabetical in the "my places" - section (A>Z or Z>A)

@sonora
Copy link
Member

sonora commented Mar 12, 2023

Maybe @Chumva could take a look. I have not investigated where we perform the folder sorting.

And it's weird that I cannot reproduce, for me the folders are sorted ok A-Z, both the order of the tabs in the ribbon and on the "Switch folder" dialog. (Other than the folder displayed as "Tracks", which is actually the root of the tracks folder and sorted to the top, probably ok.)

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 13, 2023

The tabs on this screen should only display top-level folders. It will be fixed in the main task.

@dmpr0 dmpr0 closed this as completed Mar 13, 2023
@sonora
Copy link
Member

sonora commented Mar 13, 2023

@Rowin63 Are your folders shown above nested subfolders of each other (which would explain the phenomenon as per #16663 (comment) ),or are they all immediate subfolders of "tracks"?

@Rowin63
Copy link
Author

Rowin63 commented Mar 13, 2023

I dont use subfolders at all.
All my track-folders are immediate (sub)folders of "tracks".

On two "Galaxy S20+" I use the same synced data in v4.4.1 and in v4.4.0#14233
(+) is alphabetical
(~) is mixed up

@sonora
Copy link
Member

sonora commented Mar 13, 2023

So in that case IMHO we are looking at a true issue here not yet understood, which was closed prematurely, allow me to re-open.

@sonora sonora reopened this Mar 13, 2023
@Rowin63
Copy link
Author

Rowin63 commented Mar 13, 2023

I cant switch back to an earlier nightly release to find out. I dont remember anymore exactly in which release this appeared, must have been in one of the last builds before release 14226. But sure it was not from the beginning, when you started with this new track menu. Then all items were in a correct order and not mixed up.

@vshcherb
Copy link
Member

Currently tabs are sorted by last modified date which was before default, so it should stay as before, indeed we need to introduce Folder Sorting Name or Time cause this is more convenient then alphabetical

@vshcherb vshcherb added and-ui and removed Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning labels Mar 13, 2023
@vshcherb vshcherb added this to the 4.4-android milestone Mar 13, 2023
@vshcherb
Copy link
Member

For backward compatibility and previous release tab order should be the same as in My Places cause this screen will remain untouched for now and it follows the sorting selected.

@Rowin63
Copy link
Author

Rowin63 commented Mar 13, 2023

...indeed we need to introduce Folder Sorting Name or Time cause this is more convenient then alphabetical

Sorry, I dont unterstand this...?
Name is more convenient than alphabetical? Whats the difference?

In the "previous" my-places-menu track-folders are always sorted A-Z or Z-A.
Is this name or alphabetical?

I use 40+ track-folders and I would find it very laborious to search for a folder named "A..." and find it somewhere in between or at the end of all others.

Do I misunderstand something?

@vshcherb
Copy link
Member

Nope not always, if go to My Places it's sorted as you select it. And here it should follow the same sorting.

@Rowin63
Copy link
Author

Rowin63 commented Mar 13, 2023

Ups I see, there is also an option "last edited". Never used it...
Everything will be fine with these three options in the new menu 👍

@sonora
Copy link
Member

sonora commented Mar 13, 2023

CanI suggest that

  • we make the sorting criterion global, i.e. whatever you apply is used for folders/tabs, as well as for the tracks on each tab. That's how it is in the legacy screen, has worked well. And that's how most file manager apps jandle it.
  • It saves us having yet another button or interface, and potential corresponding more mouse clicks. Also, the sorting is instantaneous now, so it's a one click / one second action to change whenever needed?
  • Regarding the subfolders, also here I think it is madatory for clarity that we do like on the old screen: We display the entire sub-path below the tracks folder, not just the lowest folder name?

@vshcherb
Copy link
Member

You can suggest, but now it's different we used to have global sorting tracks / folders but now it's separate.

  • Sorting in each folder will be preserved
  • Sorting will be saved globally between sessions and screens My Places / Configure Map (will be fixed)
  • Until we reintroduce folder sorting (present on My Places), tabs will follow sorting on My Places (will be fixed)
  • For subfolders (for now, path will be displayed in the categories screen, but won't be in the tbas)

@sonora
Copy link
Member

sonora commented Mar 13, 2023

I wonder how "path will be displayed in the categories screen, but won't be in the tabs" can be usable for any sorting other than "A-Z", where at least you can conclude that the parent folder is the tab immediately to the left...

For all I can think of right now, the way around this could be to abandon the "scrollable tab ribbon" for a "tappable path widget" like in the mockup below: That seems superior both in fuctionality and handling?

Screenshot_20230313-200117_My Files

@Rowin63
Copy link
Author

Rowin63 commented Mar 14, 2023

If I edit the color setting of a track in this new menu, all other, previously untouched tracks, do also get this settings.
It seems, that my editing always applies to all "untouched" tracks.
The ones I edited before are not affected.

@Rowin63
Copy link
Author

Rowin63 commented Mar 14, 2023

And please, try to find a simple solution how to work with this menu.

Lets say, I have three folders, every one includes 50 tracks. In each of these folders I want to edit 10 tracks, every 10 in with a specified color. How to proceed? It seems a bit complicated.

  1. I have to deselect all actual displayed tracks.
  2. go to first folder and select the 10 out of 50, edit them and apply
  3. have to deselect all actual displayed tracks again.
  4. go to second folder and select the 10 out of 50, edit them and apply
  5. have to deselect all actual displayed tracks again.
  6. go to third folder and select the 10 out of 50, edit them and apply.
  7. now I have to go to folder one and two again and have to check every single track I´ve edited right now, one by one to display them.
  8. And now, if now I want to edit other tracks in a fourth color, I have to startover from the beginning going through all the selecting procedure again, one by one.

At least I miss a "select all" checkbox in a folder.
In the "previous displayed"-tab I only can see the tracks from the very last session (it´s not as extensive as the regular "track history")

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 14, 2023

@Rowin63 this menu is not for described task. You can do it in new My Places – Tracks menu.
First and main task of this screen is to show list of tracks visible on the map, and ability to turn on more or disable visible.

@Rowin63
Copy link
Author

Rowin63 commented Mar 14, 2023

I can´t do this editing steps in the "my places"-menu. There I only can switch on and off selected tracks.
If I want to edit tracks, I have to use "configure map" and am forwarded to the new menu.
For displaying tracks on a map (simple turn on and off) I really don´t need this new menu. This is already very easy in the existing "my places".

Your first intention for this new menu was "editing more than one track in one go". Have to seek for this post here.

@Rowin63
Copy link
Author

Rowin63 commented Mar 14, 2023

sonora noted: "it currently seems like we are expanding Configure map > Tracks to be a powerful configuration screen?"
vshcherb answered: "yes exactly"

"powerful configuration screen" sounds more than just switching on and off.

@sonora
Copy link
Member

sonora commented Mar 14, 2023

Absolutely no need to have and maintain 2 screens in the long run. Every file manager logic can fulfill both purposes, mark one/several/no tracks, and configure/open/manipulate them from one control logic.

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 14, 2023

I can´t do this editing steps in the "my places"-menu. There I only can switch on and off selected tracks. If I want to edit tracks, I have to use "configure map" and am forwarded to the new menu. For displaying tracks on a map (simple turn on and off) I really don´t need this new menu. This is already very easy in the existing "my places".

Your first intention for this new menu was "editing more than one track in one go". Have to seek for this post here.

Yes, we didn't start to implement it.

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 14, 2023

Absolutely no need to have and maintain 2 screens in the long run. Every file manager logic can fulfill both purposes, mark one/several/no tracks, and configure/open/manipulate them from one control logic.

But we will.

@Rowin63
Copy link
Author

Rowin63 commented Mar 14, 2023

As I understood by now, the "old" my places / tracks section is to be replaced by the "new" configure map / tracks menu.
Am I right or wrong?
If it is not, then it´s useless for me spending my time with any beta of the "new" menu, just for switching on and off tracks.
As a user who really likes Osmand I need and want a possibility to edit the look of a bunch of tracks in one go, comfortable and logic.

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 14, 2023

As a user who really likes Osmand I need and want a possibility to edit the look of a bunch of tracks in one go, comfortable and logic

As I mentioned early many times, we didn't start to implement it. But we have prepared task that just wait until developers start to work on it. Updated Tracks screen in My Places will include all needed actions.

If it is not, then it´s useless for me spending my time with any beta of the "new" menu, just for switching on and off tracks.

Yes you are right, and you don't need to spend any time on this screen if you want to edit favorites or upload edits to OSM.

@sonora
Copy link
Member

sonora commented Mar 14, 2023

@dmpr0

Maybe I misunderstand and hope it is due to some language barrier, but it seems you always try to confront us with "set decisions just not yet implemented", while we make suggestions how a concept could look that would potentially be significantly more useful and favorable?

Why is it that we cannot have an open discussion about the improvement ideas people develop and post, based on objective reasoning, without the knockout "It will not be like this." ??

@Rowin63
Copy link
Author

Rowin63 commented Mar 15, 2023

If I´m through all the procedure mentioned above, then I´m back in the new "configure map / tracks"-menu and I see, for some reason I missed to cofigure the appearance of only one track (like in the screenshot), I can not do this from here where I am now, because any change I do would apply to all 158 previous (different) configured and displayed tracks (and I dont want to deselect them again, it was already a long "selecting" way until here).

I have to exit this menu, go back to "my places" and here I can edit the appearance of this single track. So far so good, of course it´s a way to do it. Now you give me two different menues, which basicly do very similar things, like track displaying and editing track appearance.

But:
) in one menu (my places) I don´t have any idea of the appearance of a group of tracks, but I can easily edit a single one.
) in the other menue (configure map / tracks) you give me a very good overview of a tracks appearance, but I can´t edit (easily/comfortable) a single one (like when my 158 other tracks are displayed).

Here in this new menu I still struggle a) with the "checking options" and b) with the fact, that editing always applies to all displayed tracks (selected here = displayed). An option here selected = editing (independend to the displayed tracks) would be a really great and helpful option. It would be so easy then, to configure different groups of tracks in different appearance and when finished, displaying them or not.

This is my intention from the beginning, when weeks ago I first started asking for an option to configure more than one track in one go.

Configuring detached from displaying. This can be seen as the point of it.
Just my opinion. Thanks.

Screenshot_20230315_082113_OsmAnd+

@sonora
Copy link
Member

sonora commented Mar 15, 2023

And I hope the plan is not to introduce a third screen for that use case... 😉😘😉

Forgive me - just kidding. 😉

@Rowin63
Copy link
Author

Rowin63 commented Mar 15, 2023

Of course not 😉
Each of this two existing possibilities has mighty options - and somehow they´re very different, though being verry similar on the other hand.

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 15, 2023

Hello, @sonora ! Thank you for the feedback.
If you have any other questions please contact us at support@osmand.net

@vshcherb
Copy link
Member

every file manager has 2 or even more modes: 1 to browse, 1 to select, 1 to paste item. The could seem very similar but actions and menus and behavior in each mode is different. So in the end it will be more clear what is different on selection screen / search / browse etc.

@vshcherb vshcherb changed the title Allow to sort Tabs - Configure Map Tracks Allow to pin Tabs (sort) - Configure Map Tracks Apr 17, 2023
@vshcherb vshcherb modified the milestones: 4.5-android, 4.6-android Apr 17, 2023
@vshcherb
Copy link
Member

Tabs sorting could be very confusing cause tabs is a flat list but folders could be nested. So only 1 type of sorting could be non-confusing (A-Z / Z-A).

So we decide that most important for users is to pin individual folders and filters.

@vshcherb
Copy link
Member

As smart folders will be displayed first it's possible they will be configurable and this task will rely on #18221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants