Custom search filter doesn't reset after being modified

[ceever]

Description

I have a custom search filter specifically for "Tourist Attraction" (i.e. tourism=attraction), which I have stored to always access it quickly.

However, when changing it, e.g. by addition a name in the filter, the filter stays this way even after leaving the search or restarting OsmAnd. That shouldn't be since I never stored the modified custom filter. Also, it is almost impossible to reset the filter, deleting the additional name filter doesn't work by removing it and moving out of that view. Only when putting a space character, the custom filter is reset to its original version.

See screenshots:

Steps to reproduce

1. Create a custom "Tourist attraction" filter.
2. Use it
3. Add a name to the custom filter
4. See it working
5. Search for something else like "Restaurant and cafe" and see results
6. Move back to your custom "Tourist attraction" filter as a search
7. Observe that it still containing the previously put name, even though you never stored it like this anywhere

Actual result

Any modifications to the custom filter are stored indefinitely, without any "Save filter" button pushed.

Expected result

An additional name (and any other) modification of a stored custom filter should not automatically be stored itself. Instead, the original custom filter should turn up again after reselecting it after some other actions.

Even if this is a "function as implemented", the name reset is not clear. Removing the name filter results in there is not being any button "apply filter", which would reset the filter indeed. But only when putting a space character the actually unnecessary reset it possible.

Meaning: Any stored custom filter is reset to its originally stored version after one has moved to a different action in OsmAnd.

Your Environment (required)

OsmAnd Version: 4.5.10
Android/iOS version: 9
Device model: Galaxy S8
Crash-Logs: ?

[yuriiurshuliak]

The bug has been reproduced. To reproduce, please use the following steps:

• Make a "Tourist attraction" Custom POI filter
• Find and open this Custom filter
• Click the 3-dot icon on the top right
• In the "Filter by name" field, input a category like "statue," hit "Apply filters," and view the result
• Close the filter, and search for something else like "Cafe"
• Reopen the "Tourist attraction" Custom POI filter; you'll observe that the "statue" selection remains and can't be reset.

OsmAnd~ 4.6.0#1071m, released: 2023-11-22

video_2023-11-22_14-48-01.mp4

[vshcherb]

To do: filter should reset if it's open from search again, though for history it needs to check how it works... Preferrably history should display that it has configruation and store but it could be a separate task