Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map zoom after searching for categories or housenumber should be increased #18901

Closed
Max1234-Ita opened this issue Jan 12, 2024 · 13 comments · Fixed by #19138 or #19187
Closed

Map zoom after searching for categories or housenumber should be increased #18901

Max1234-Ita opened this issue Jan 12, 2024 · 13 comments · Fixed by #19138 or #19187

Comments

@Max1234-Ita
Copy link
Contributor

Max1234-Ita commented Jan 12, 2024

Description

I've noticed that, when searching for an address or a POI by category, the map zoom factor is adjusted to 15 and I have to manually zoom in to see more details.

I think this value is too little and should be increased a bit, at least to '17 or '18', in order to provide the user with a better view of the selected location and its neighbourings.

Steps to reproduce

  1. Launch OsmAnd
  2. Enable the OsmAnd Development plugin and put the 'Zoom factor' widget in any panel (i.e. right panel)
  3. Open the Search menu -> Address and search for a complete address (city + street + housenumber)
  4. Select the desired result and show it on map; notice that the zoom factor is set to '15'
  5. Manually zoom in to factor 17 or 18: the chosen location is way more visible.
  6. Open the Search menu -> Category and search for a POI; show it on map and notice that the zoom factor is set to '15' again. Manually zoom in for more details

Actual result

After searching for an address or POI, zoom factor is set to 15

Expected result

Setting the zoom to 17 or 18 would immediately give the user a better view with more details on the chosen location without having him/her to zoom in manually.

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive.
Review this CAREFULLY before posting your issue!

OsmAnd Version: OsmAnd Nightly 4.7.0 #1356m, released 2024-01-12
   Observed also on OsmAnd Plus v. 4.6.11

Android/iOS version: Android 14, Android 11
Device model: Google Pixel Tab (emulated), Samsung Galaxy A50 (physical)
Crash-Logs: None
@Sonwon1
Copy link

Sonwon1 commented Jan 12, 2024

I would add, make this user definable.

@vshcherb
Copy link
Member

vshcherb commented Jan 12, 2024

Agreed.

To do:

  • Zoom should be 16. Cause that's default zoom to display Buildings and for searching a specific POI / Favorite / Waypoint / building / house 16 should be default. For streets, cities and other search results it could stay lower as it is.

@vshcherb vshcherb added this to the 4.7-android milestone Jan 12, 2024
@Max1234-Ita
Copy link
Contributor Author

Max1234-Ita commented Jan 12, 2024

Agreed. To do: Zoom should be 16 cause that's default zoom to display Buildings and for searching a specific POI / Favorite / Waypoint / building / house 16 should be default. For streets, cities and other search results it could stay lower as it is.

Hmm, I think 16 is still a little too low, however.

The town I live in has about 40000 inhabitants: if I search for a particular building, of which I know the house number, with zoom = 15 I can see all all of it, plus some surroundings; with 16 I see almost all the town centre; I think 17 would be good, 18 is great but you lose a little the overview, so I would candidate 17 as an optimal value to be adopted.

Attaching some pictures taken from my smartphone.

Anyway, I think @Sonwon1 is not wrong, the best would be adding an option in OsmAnd settings, allowing the (advanced) users to set the default value they prefer.

Zoom == 15
Screenshot 1

Zoom == 16
Screenshot 2

Zoom == 17
Screenshot 3

Zoom == 18
Screenshot 4

@Sonwon1
Copy link

Sonwon1 commented Jan 12, 2024

Just make it user adjustable, problem solved. Give the user control!

@Corwin-Kh Corwin-Kh self-assigned this Feb 15, 2024
@sonora
Copy link
Member

sonora commented Feb 16, 2024

Well, yet another user setting, we must have hundreds by now. And then in every profile, I guess? 😉

Trouble is that there is probably no one answer, not even one answer per user if you could adjust it. The issue above assumes that when you look for something you always,want to view the immediate vicinity of it, i.e. the surroundung buildings. But in as many cases I find myself not caring about the neighboring buildings, but trying to find out in which part of town or suburb something is located (like e.g. a hotel).

So I guess there is no good one answer, not even if this were user definable. I always simply use the (+)/(-) zoom buttons depending on the actual use case, and would say @vshcherb 's suggestion of zoom 16 seems good enough as a starting point in all directions?

@Sonwon1
Copy link

Sonwon1 commented Feb 16, 2024

Well, yet another user setting, we must have hundreds by now. And then in every profile, I guess? 😉

Trouble is that there is probably no one answer, not even one answer per user if you could adjust it. The issue above assumes that when you look for something you always,want to view the immediate vicinity of it, i.e. the surroundung buildings. But in as many cases I find myself not caring about the neighboring buildings, but trying to find out in which part of town or suburb something is located (like e.g. a hotel).

So I guess there is no good one answer, not even if this were user definable. I always simply use the (+)/(-) zoom buttons depending on the actual use case, and would say @vshcherb 's suggestion of zoom 16 seems good enough as a starting point in all directions?

This is why I believe default settings that a user could change in an advanced settings menu would be the best solution. This allows everyone to use OsmAnd as they need and not how they are told it should be used. If you are worried about a user messing things up then include a return to default action in the menu.

@sonora
Copy link
Member

sonora commented Feb 16, 2024

Yes, but my point was even if you had this setting, depending on what you search for on different occasions you may find it needs a different value on every occasion? Which is more complex and less intuitive than just tapping +/- as needed for every use case?

@Sonwon1
Copy link

Sonwon1 commented Feb 16, 2024

Exactly, which is why it is important to let the user decide which setting best suits their needs since not one default will work in all cases.

I am advocating for a design philosophy in whole not for just this setting. I left Google Maps because it became to restrictive and features were removed. I also left Garmin for the restrictions. Now on an Android tablet I can run OsmAnd and OBDII dashboard in split screen mode. I came here for the flexibility. I like to see all of the data that Garmin and Google Maps hides from me. As far as I can tell OsmAnd is currently the most flexible and feature rich nav/mapping app.

@sonora
Copy link
Member

sonora commented Feb 17, 2024

Yeah, we both agree, I'm not trying to hide anything. I am simply pointing out that a setting whichh would need frequent adjustnent per use case is questionable.

@Corwin-Kh Corwin-Kh linked a pull request Feb 19, 2024 that will close this issue
Chumva added a commit that referenced this issue Feb 19, 2024
…zoom

#18901: changed default zoom for search objects
@dmpr0
Copy link
Contributor

dmpr0 commented Feb 20, 2024

Review

  • Taping first time on house number search result, open map on 14 zoom level, second and next on 16.

House number

First open Second open Video
HouseNumber.mov
City – 15 POI from search – 16 Search > POI > Show on map – 12

@dmpr0 dmpr0 reopened this Feb 20, 2024
@DmitryAlexei DmitryAlexei added the ~ label Feb 23, 2024
Chumva added a commit that referenced this issue Feb 26, 2024
@Chumva Chumva linked a pull request Feb 26, 2024 that will close this issue
@Chumva Chumva closed this as completed Feb 26, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Mar 18, 2024

Review

  • Todo is missed. Based on available information I can't understand what was done and create task for iOS team.

@dmpr0 dmpr0 reopened this Mar 18, 2024
@vshcherb
Copy link
Member

Implemented algorithm

  • If search object could be visible with previous map center (before search) to extent of ZOOM - 2, then map just zooms out and center moves to search object. For example, my location is in center with zoom 16, nearby searched POI is in 300m but doesn't fit visible bbox of zoom 16 and fits bbox on zoom 14 so both my location and searched POI is visble.
  • In all other cases when zoom out doesn't help to see previous map center and search POI default constants are used:
    • POI / Building - 16
    • Street - 15
    • City - 14

@vshcherb
Copy link
Member

vshcherb commented Apr 8, 2024

IOS always uses 16 zoom in search should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment