Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotted line to indicate toll road dependent from too many facts #19087

Closed
pebogufi opened this issue Feb 12, 2024 · 25 comments
Closed

dotted line to indicate toll road dependent from too many facts #19087

pebogufi opened this issue Feb 12, 2024 · 25 comments
Assignees
Milestone

Comments

@pebogufi
Copy link

pebogufi commented Feb 12, 2024

Description

The display of the dotted line of toll roads on streets depends on zoom level (ok),
map style (bug?),
presence of world overview map (NOT mini) (bug)

Steps to reproduce

dotted line is visible if
zoom level > ~10 AND
map style is in (OsmAnd, Mapnik, Desert) AND
world overview map (NOT mini) DEactivated

if different map style (touringview, ?)
OR world overview map activated
then
dotted line is visible if
zoom level > ~12

For planing a longer trip it is better to see dotted line on lower zoom levels like 10. So for planning i have to deactivate world overview map to get more overview

Actual result

See above

Expected result

See above

Your Environment (required)

OsmAnd Version: OsmAnd~ 4.7.0#1572m, veröffentlicht: 2024-02-12
Android version: 10
Device model: samsung tab S5e
Crash-Logs: no

@pebogufi pebogufi changed the title dotted line to indicated toll road depedent from too many facts dotted line to indicate toll road depedent from too many facts Feb 14, 2024
@pebogufi pebogufi changed the title dotted line to indicate toll road depedent from too many facts dotted line to indicate toll road dependent from too many facts Feb 14, 2024
@yuriiurshuliak
Copy link

yuriiurshuliak commented Feb 19, 2024

I tried to reproduce the problem by comparing two map styles, OsmAnd and Touringview and with the world overview map enabled. At zoom level 12, the dashed toll line is displayed in both styles and with the world overview map enabled. However, at zoom level 10 the Access Toll is represented by a dashed line exclusively in the OsmAnd map style, while in Touringview it is shown as solid orange-yellow lines. And when the world overview map is turned on, it is not displayed at all.

It is worth noting that different map styles satisfy different requirements, and the variations observed may be influenced by the specific characteristics of each style.

OsmAnd~ 4.7.0#1627m, released: 2024-02-19

OsmAnd Touringview Activated world overview map
OsmAnd Touringview Activated world overview map

@pebogufi
Copy link
Author

I understand that different map styles show different objects, that is no problem for me.
But i don't understand that the presence (visibility) of world overview map inhibits the dotted line for some map styles for zoom level 11 and 12.
Is it possible that world overview map overwrites regional map (dotted line) at theese two zoom levels with the motorway line red/yellow/red ?

@sonora
Copy link
Member

sonora commented Feb 19, 2024

Hm, not sure I can reproduce the issue, I just looked at Rome and it seems the toll roads around Rome are correctly shown using the Touring View map style: I also cannot find any dependency of this on the presence or not of any other maps, like the any world overview maps... (Toll in Touring View are the purple dashes. The red/orange is the standard for "motorway"):

@pebogufi
Copy link
Author

Yes, touring view has the problen to see dotted line only with zoom level > ~12, see my first statement.
Please try with map style in (OsmAnd, Mapnik, Desert) AND then
world overview map (NOT mini) DEactivated
Or activated.

  • DEactivated - dotted line visible when zoom level > ~10

  • activated - dotted line visible when zoom level > ~12

@pebogufi
Copy link
Author

@sonora
Looks like you use rendering engine 1, I can confirm that it shows dotted line wth Touring View from zoom 10, thats ok, i love it !
But with rendering engine 2 it shows dotted line with Touring View only from zoom level 12.

@pebogufi
Copy link
Author

pebogufi commented Feb 20, 2024

... and i confirm that dependency of the presence of any other maps, like the world overview maps is only a problem with new rendering engine 2, no problem with r.e. 1.
Sorry since some months I use only the new r.e. 2, i did not report that or check it before.

@sonora
Copy link
Member

sonora commented Feb 20, 2024

@pebogufi Ah, ok, yes, in deed I was testing with v1.

I noticed that there had been some small changes to the file some months ago obviously trying to fix some Touring View behavior with the v2 engine, which had elapsed me. I have now made an obvious correction which may fix the issue: osmandapp/OsmAnd-resources@3406f45. Does that solve it?

@pebogufi
Copy link
Author

Ok, thanks. Now the dotted line for touringview is visible also from zoom level 10 like OsmAnd, Mapnik, Desert
BUT ONLY if world overview maps is DEactivated.
If activated, it is visible only from zoom level 12.
For me, that is the major problem.

@sonora
Copy link
Member

sonora commented Feb 21, 2024

Right, so it sounds the Touring View specific peculiarity has been resolved and now it needs to be checked why with the v2 engine the world map supresses the toll road display for zoom 10 and 11...

@vshcherb
Copy link
Member

Would need some investigation from @xmd5a2 to understnad whether it map data issue or rendering engine

@vshcherb vshcherb added this to the 4.7-map milestone Mar 16, 2024
@xmd5a2
Copy link
Contributor

xmd5a2 commented Mar 21, 2024

Dev notes: looks like Basemap_SimplifyRoads job is broken.

@DmitryAlexei DmitryAlexei added the ~ label Mar 25, 2024
@xmd5a2
Copy link
Contributor

xmd5a2 commented Mar 26, 2024

Basemap was fixed and updated. Please retest this:

Right, so it sounds the Touring View specific peculiarity has been resolved and now it needs to be checked why with the v2 engine the world map supresses the toll road display for zoom 10 and 11...

1.Turn on "Show toll restrictions" in Configure map - Details. Ensure that rendering engine is OpenGL.
2.Download full basemap
3.Download Russia_moskovskaya-oblast_asia map
4.Go to https://www.openstreetmap.org/way/870545810 and see that it has dots on it at zoom 10-11
Zoom 10:
изображение

Zoom 11:
изображение

@pebogufi
Copy link
Author

Confirm fixed, now I like it so much 😃
Thanks a lot, Peter

@pebogufi
Copy link
Author

pebogufi commented Mar 27, 2024

@pebogufi Ah, ok, yes, in deed I was testing with v1.

I noticed that there had been some small changes to the file some months ago obviously trying to fix some Touring View behavior with the v2 engine, which had elapsed me. I have now made an obvious correction which may fix the issue: osmandapp/OsmAnd-resources@3406f45. Does that solve it?

@sonora
Due to your fix I know where the zoom factor can be set. Thanks a lot. Currently I set it after every update to 8 which is fantastic for planing long travel.
Could you please set it to 8 in the resources ?
This would be really great 🌞

@sonora
Copy link
Member

sonora commented Mar 28, 2024

Ok, let's try! ;) Untested, so please let me know if its really worth it and does not provide more clutter than benefit!

@pebogufi
Copy link
Author

@xmd5a2
NEW BUG in new version of new created "world overview map".
In France a part of a motorway is now tagged as "with toll" which is wrong, see detail local maps.
E11 (A 75) south of Clemont-Ferrand
Wrong part starting near Brioude 45.29450 N, 3.24316 E
to south
Beziers 43.33950 N, 3.29621 E
Between theese two points is only a smal part WITH TOLL, the bridge in the west of Millau "Viaduc de Millau" 44.07866 N, 3.02333 E.

@sonora
Copy link
Member

sonora commented Mar 29, 2024

Perhaps it's not such a good idea to use minzoom=8 for the toll road display? Because that takes the data off the overview map, and I am not sure it's valid rhere and detailed enough... pls let me know.

@pebogufi
Copy link
Author

pebogufi commented Mar 29, 2024

I use "8" since your change at Feb 20, just setting it by hand after every app update in Touring-view_(more-contrast-and-details).render.xml
line 1321 and I am absolutely happy with it.
I am traveling through south of france since 3 weeks.
It is perfect for planing over some distance and of course also present when zooming more in.

@pebogufi
Copy link
Author

pebogufi commented Mar 30, 2024

One more hint.
The option "show access restriction" was divided into

  • "show access restriction"
    and
  • "show toll restriction"

In Touring-view_(more-contrast-and-details).render.xml this change was NOT made,
toll works with "show access restriction" until now.

In map style OsmAnd and Mapnik
toll works with "show access restriction" until now.

Edit: I did not find a situation where "show toll restriction" was used for toll detection, allways "show access restriction" is used.

@sonora
Copy link
Member

sonora commented Mar 30, 2024

Regarding the new separation between access restriction and toll: Yes, there's more and more diversification and detailing happening, which increases not only the complexity and effort for code maintenance (and opens new occasions for bugs to occur and performance to slow), but in the end also demands more time from users to configure everything to their liking and usability. :( Oh well, I can take the time to look at it...

@vshcherb
Copy link
Member

vshcherb commented Apr 1, 2024

If basemap generated please close it @xmd5a2

@xmd5a2
Copy link
Contributor

xmd5a2 commented Apr 2, 2024

@pebogufi Please create a different issue for this (#19087 (comment))

@xmd5a2 xmd5a2 closed this as completed Apr 2, 2024
@xmd5a2
Copy link
Contributor

xmd5a2 commented Apr 2, 2024

How to test: #19087 (comment)

@dmpr0
Copy link
Contributor

dmpr0 commented Apr 11, 2024

Review

@dmpr0 dmpr0 reopened this Apr 11, 2024
@vshcherb
Copy link
Member

Reverted to combined option of toll//access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants