Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not switch profile during initial Route calculation #19166

Closed
vshcherb opened this issue Feb 22, 2024 · 7 comments
Closed

Do not switch profile during initial Route calculation #19166

vshcherb opened this issue Feb 22, 2024 · 7 comments

Comments

@vshcherb
Copy link
Member

Testing it more and more, I think the change that was made last years, I do not feel comfortable at all.

Initially profiles were assumed mostly for active navigation, so in case I calculate car route it doesn't mean I'm ready to go with Car I just want to see the route. Though over time implementation has changed

Negative impact that I feel with current solution:

  • Switch of all preconfigured widgets when I just want to see any route
  • Switch between day/night map mode
  • Switch map orientation that for viewing route is not good as mostly preffered to view with North Up

I couldn't backtrace in which issue it was introduced so please feel free to comment

@vshcherb vshcherb added this to the 4.7-android milestone Feb 22, 2024
@Rowin63
Copy link

Rowin63 commented Feb 23, 2024

My 2c to the "north up" issue are in here #18805
And the switching from day to night bothers me too sometimes. A little bit.
I would prefere to remain in the "see map" profile with all it's settings and widgets, until tapping "start".

@scaidermern
Copy link
Contributor

Not sure why this needs a new ticket instead of reopening and fixing #18805 but great to hear that this change will be reverted!

@dmpr0
Copy link
Contributor

dmpr0 commented Feb 23, 2024

Hi, @vshcherb !
Did you try to switch Default profile to Last used in MenuSettingsOsmAnd Settings? It would fix two of three issues you have described.

@vshcherb
Copy link
Member Author

#18805 Nope this won't be implemented cause we need special "mode" of route planning which is not planned for now. Instead I propose to not change App profile when you didn't start navigation, so it will keep using Browse Map profile.

@vshcherb
Copy link
Member Author

@dmpr0 - changed to last used, no changes I see.

@sonora
Copy link
Member

sonora commented Feb 23, 2024

I propose to not change App profile when you didn't start navigation, so it will keep using Browse Map profile.

Yes! Thank you Victor! 😉

(PS: This is where we changed things: #13657)

@dmpr0
Copy link
Contributor

dmpr0 commented Feb 26, 2024

@dmpr0 - changed to last used, no changes I see.

That means you don't start Navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants