MyPlaces>Tracks root folder and subfolders lose sorting order

[sonora]

Have to re-open this. With intense use in the last 2 weeks, at least once daily the sorting order of MyPlaces>Tracks and its subfolders resets to "Last modified", while I positively always set everything to A-Z.

There must be one or several remnants in our code always setting things back to "Last modified".

Candidates are after a fresh app start, manual profile change, a navigation (without using turn-by-turn mode), or after making more track folders visible on map.

[scaidermern]

A never ending story ☹️

• My Places > Tracks: Sorting order at My Places gets reset to last modified #17955
• My Places > Tracks: Sorting order gets lost #17475
• MyPlaces > Tracks loses its sorting #17278
• Configure map / tracks > sorting #17315

[scaidermern]

In #17955 I added a video how to reproduce this bug.

And just now I reproduced it by simply changing the visibility of two tracks to false. This also changed the sorting order of the tracks root folder.

[yuriiurshuliak]

The bug has been reproduced. I managed to reproduce it on the current release version, but it's not occurring on the latest nightly version. To reproduce the bug on the release version, navigate to "My places" and ensure that the "Sort by" option in both the Tracks and Visible on map folders is set to "Last modified" mode. Then attempt to switch the sorting in both folders to "Name: A - Z" mode, and after confirming the last change, click on the cross in the upper left corner and return to the map. Revisit the "My places - Tracks" folder, and you'll observe that the sorting automatically reverts to "Last modified" mode.

OsmAnd 4.6.13, released: 2024-01-19
OsmAnd~ 4.7.0#1864m, released: 2024-03-19

Release version	Nightly version
video_2024-03-19_16-01-05.mp4	video_2024-03-19_16-01-07.mp4

[sonora]

I believe there are multiple different ways to independently reproduce issues about the sorting order of the new tracks screens. Someone knowledgeable about that code should go tyhroug the entire code base, search for places where the sort order is changed, and check for potential occurences of unwanted changes happening... or else we may not fix these issues for good for another long time...

[sonora]

Side note: about something which confuses some readers of the screenshots and recordings:

When using the "Sort subfolders" action, its initial screen highlights one of the sorting options with a color. By convention you may think this is the current sorting order used for the subfolders, but in fact it seems not. (In fact it even shows if not all subfolders are sorted the same.) Not sure what it means to be - perhaps the highlighting needs removing here to avoid confusion.

[Rowin63]

I don´t know why, but all my tracks sub-folders are set back to sorting "last edited".

[Rowin63]

I think, changing Osmands data folder could have caused it.
And new created folders do have this sorting as "standard".

[sonora]

In my cases it had nothing to do with changing the data folder or creating new folders... happens during app use, with just occasionally displaying/hiding groups of tracks.

[vshcherb]

@sonora it's impossible that setting would randomly changed, @Chumva please share what setting is for sorting and where it's possibly changed in the code

[Rowin63]

After editing some folders names, the listing gets mixed up in "configure map>tracks"

But it is correct in "my places > tracks"

[sonora]

Yes, same here. Let's please also fix in this issue, or if needed we can create a second one.

[Rowin63]

Yes, same here. Let's please also fix in this issue, or if needed we can create a second one.

You may activate my previously created ticket (#19634), if you want to (I closed it again, because I was not sure if it´s a double of this here or not) Thanks!

[vshcherb]

The problem of that issue it's still in reproducing phase (I hope we will get more time to put some logs after release rush)

[sonora]

With this commit for #19634 it is now like this:

• Sort MyTracks A-Z (both root screen and subfolder sorting).
• On that screen tap on 'Visible on map', (there all tracks are falsely sorted by 'Last modified'). Tap a track and 'Apply', to show it on the map. (Or remove a visible one from the map, this also reproduces the issue.)
• Re-enter Menu/MyPlaces/MyTracks: Now root folder and also all subfolders' track sorting has reverted to 'Last modified'.

And PS: This fix increases for my setup (3500 tracks in 70 subfolders) the time to enter that screen which was meanwhile down to 2-3sec to like 15+ sec again... (every time I enter it, there seems no caching or remembering)

[Rowin63]

And PS: This fix increases for my setup (3500 tracks in 70 subfolders) the time to enter that screen which was meanwhile down to 2-3sec to like 15+ sec again... (every time I enter it, there seems no caching or remembering)

THIS is exactly the behavior I have on my Tablet (Galaxy Tab S6), since a few releases (maybe a month or so?). Takes around 20s every time I open "my places / tracks" or "configure map / tracks".
I did a complete fresh install but it did not change (latest Osmand+ 4.7.11)
The tablet runs Android 12.
I dont see this issue on my other devices, all running Android 13 (Android 12 seems to be the only difference). Didn´t open an issue yet, was searching the cause on my side. Have the same data on all devices (reduced track data, not as many as before).

[sonora]

Looks like the problem is associated with the "Visible on map" tracks screen, we have 2 error cases:

1. Any sort modification (also to e.g. 'Nearest') on any tab of the 'Visible Tracks' screen resets the 'MyPlaces>Tracks' screen (and its subfolder sorting) to 'Last Modified'.
2. Adding or removing a track to/from 'visible' via the 'Visible on map' screen (independent of how the 'On map' folder is sorted) resets the MyPlaces>Tracks screen (and subfolder sorting) to 'Last Modified'.

'Last modified' is the default value. So if we forget to set the sortMode somewhere, or try to set it to something invalid, that would cause this effect.

[sonora]

@Chumva BaseTrackFolderFragment.java's TracksSortMode getTracksSortMode() is the very method eventually causing this, I've verified that both error cases come from exactly this line:

OsmAnd/OsmAnd/src/net/osmand/plus/myplaces/tracks/dialogs/BaseTrackFolderFragment.java

Line 331 in 73a7b1b

return TracksSortMode.getDefaultSortMode();

And: This issue is connected to #19634: We use two different sets of sortMode settings for the MyPlaces>Tracks folders and the Visible on map screen's tabs, should use the same.

[sonora]

To elaborate: The issue comes from the different scopes of sort modes we save on the 'MyPlaces>Tracks' vs. the 'Visible on map' screens. Tentative TODOs:

1. On Configure map>Trscks we do not display a tab for folders which contain no tracks directly but only subfolders. Correspondingly, their sort order gets lost in

   OsmAnd/OsmAnd/src/net/osmand/plus/configmap/tracks/TrackTabsHelper.java

   Line 311 in 21d390d

   public void saveTabsSortModes() {

   This needs mitigating. Most prominently for the root ("Tracks") folder.

2. Reversely, the sort order for tabs which have no folder equivalent gets lost when the sort modes are saved from MyPlaces>Tracks. Most notably "ALL" and "ON MAP".

3. The sort order for the tabs needs to be synced with that of the root folder and remembered (saved) "in both directions".

[sonora]

This PR fixes (1) and (2) above #19814. It preserves the existing sort modes when saved in the two separate tack screens we have.

As a consequence, we need to have the method removeSurplusTabsSortModes() to at some point clean up the TRACKS_TABS_SORT_MODES no longer needed on both screens. For now I only call it under sortSubFolder(...), we may find better or additional places to call it, e.g. when folders are deleted.

Issue #19634 is not yet fixed by this PR. We now need code sorting the tabs on 'Configure map/Tracks' according to the 'MyPlaces>Track's' screens rootFolder's sortMode, from what I see that is so far completely missing.