Fix_19333 #19814
Merged
Fix_19333 #19814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
Chumva
reviewed
May 9, 2024
| @@ -344,6 +348,7 @@ protected String getSortEntryName() { | |||
| @Override | |||
| public void setTracksSortMode(@NonNull TracksSortMode sortMode, boolean sortSubFolders) { | |||
| if (sortSubFolders) { | |||
| removeSurplusTabsSortModes(); | |||
There was a problem hiding this comment.
Do we need to call this method every time we change sort mode & perform settings.saveTabsSortModes() two times?
There was a problem hiding this comment.
It's true that I have not found the ideal place(s) yet when to call this. It's comparatively expensive, hence perhaps should not be called after every folder move, delete or rename
In a way I 'parked' it here under the 'sort subfolders' action where it can be triggered manually via the corresponding menu option. Will come back to this as I find some time, but it's not a priority 1 issue, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.