Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and Delete actions for Custom button #19596

Closed
8 tasks done
dmpr0 opened this issue Apr 17, 2024 · 1 comment
Closed
8 tasks done

Rename and Delete actions for Custom button #19596

dmpr0 opened this issue Apr 17, 2024 · 1 comment
Assignees
@Chumva
Labels
! and-quick-action doc-✍️
Milestone
4.7-android

Comments

@dmpr0
Copy link
Contributor

dmpr0 commented Apr 17, 2024 •
edited by Chumva

Description

We need to add actions for Renaming and Deleting custom buttons.

New action

  • Add new action to AppBar
    • Icon – ic_overflow_menu_white
    • Title – shared_string_more_actions
    • Show context menu on tap

More actions, context menu

Confirmation alerts
Rename Delete
  • Rename – open dialog with textfield
    • Icon – ic_action_edit_outlined
  • Delete – open confirmation dialog on tap
    • Icon – ic_action_delete_outlined
@vshcherb vshcherb added this to the 4.8-android milestone Apr 18, 2024
@vshcherb
Copy link
Member

Potentially to 4.7 branch if request is not complicated and 4.7 will be open

@vshcherb vshcherb modified the milestones: 4.8-android, 4.7-android Apr 18, 2024
@Chumva Chumva self-assigned this Apr 22, 2024
Chumva added a commit that referenced this issue Apr 22, 2024
@Chumva
Merge pull request #19639 from osmandapp/fix_#19596
054c5c0 
Fix #19596
@Chumva Chumva closed this as completed in 463f22f Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chumva Chumva

Labels
! and-quick-action doc-✍️
Projects
None yet
Milestone
4.7-android
Development

No branches or pull requests
3 participants
@vshcherb @dmpr0 @Chumva