NPE in track context's Point appearance menu

[sonora]

Displayed as 'Track' a GPX file which has no <trk> or <trkpt>, just several <wpt>, each tagged with one of two different <type> tags.

On the map, tap any of its waypoint icons, tap "Open track", then on the track context menu tap the 'Point' button, then "3-dots>Change default appearance'. This produces this NPE
exception.log.txt.

[sonora]

Possibly related to the issue described in #19971 (comment): We may fail to properly identify wpts' pointsGroups here, and hence also do not assign the right icon color.

[yuriiurshuliak]

I was unable to reproduce this issue. I attempted to reproduce it by selecting a track containing only <wpt> tags, then tapped the waypoint icon on the map and tried to changing default appearance. No problems related to NPE occurred.

Here's the track I used: Algeria.zip

The problem might be specific to the track used. Please upload it here so we can investigate further.

[sonora]

Perhaps because your track only contains one points_group.

EDIT: But perhaps the issue has another cause, here is a rather short file which produces the NPE crash for me: npe-test.gpx.txt

[yuriiurshuliak]

Unfortunately, attempting to access the specified track results in an error on my end.

[sonora]

Once downloaded, you probably forgot to rename it back removing the .txt extension in the end. Github does not allow sharing files here ending in .gpx, hence the little trick... 😉

[yuriiurshuliak]

No, I have already renamed the track in Total Commander and removed the .txt extension. Please let me know if it opens correctly for you.

[sonora]

My apologies, you are right - I must have fatfingered the file.

I have updated the post above with a very short npe-test.gpx file, which produces the crash for me... can you reproduce?

[yuriiurshuliak]

It's quite strange, but this file still won't open and displays an error. I tried importing it using two methods. It seems the file might be corrupted.

OsmAnd~ 4.8.0#2610m, released: 2024-06-28

video_2024-06-28_16-48-44.mp4

[sonora]

Interesting... yes, good finding. I can confirm that error when using one of OsmAnd's "import" mechanisms for file npe-test.gpx.

It is the same root cause I am reporting here, and you have it explicitly on your recording: There is some 'null' interpretation of this line <{null}osmand:points_groups .

• When you try to import the track, our import code notices the issue immediately.
• When instead you just place the track manually in OsmAnd's "tracks" folder tree, you can display the file ok. The NPE then only occurs when you try to change the Waypoint appearance using the steps I have outlined in post 1.

I see no reason why OsmAnd creates an NPE for this file at all, so I believe this needs fixing...

There is also a cross connect here to issue #19892. The 2 issues are in the same code, and should likely be fixed together.

[DmitryAlexei]

Sonora, so this issue can be closed as duplicate of #19892 ?

[sonora]

#19892 is not exactly a duplicate, because it deals with a functionality bug, while this here is about an occurring NPE. But yes, both issues should be fixed together, and hence be known to whoever tackles this.