New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map icon: Incorrect direction for turning circle in LHT countries #6932
Comments
What's your setting under Settings / General settings / Driving region? |
Automatic. It remains the same even if I change it to Australia or if I change system locale to English (New Zealand). |
Yes, Automatic should work ok. I just see, you are only talking about the icons on the map, not the navigation instructions, navigation turn arrows, etc, those are ok? |
Yes, I mean the icon on the map. I don't think OsmAnd actually takes into account turning circles during navigation, at least I don't remember it asking me to turn on one, but for everything else, it navigates correctly |
Could you please specify which icon on the map? I've thought it applies only to widget on the left and it takes into account setting which is mentioned. |
This is also happening on UK maps. I think the bigger issue is for mini-roundabouts which use the same symbol. If it isn't possible to make them 'handed' based on driving direction a solution may be to adopt openstreetmap carto's approach and use a ambidextrous "⨀" symbol for these, although I do like that the current symbol is closer to the mini-roundabout sign. |
The changes to obf_creation/rendering_types.xml in this issue's commit appear to have disabled turning circle rendering in the USA (at least Washington State), presumably elsewhere too. (I remember seeing them in the past for a while.) I suggest trying reverting the turning_loop and turning_circle line changes and moving the lhn detection line to after them. In other words, something like: + <entity_convert pattern="tag_transform" from_tag="highway" from_value="turning_loop" to_tag1="highway" to_value1="mini_roundabout" routing="no"/>
+ <entity_convert pattern="tag_transform" from_tag="highway" from_value="turning_circle" to_tag1="highway" to_value1="mini_roundabout" routing="no"/>
<entity_convert pattern="tag_transform" from_tag="highway" from_value="mini_roundabout" if_region_name="$cyprus,$malta,$gb,$ireland,$bangladesh,$bhutan,$india,$maldives,$nepal,$pakistan,$sri-lanka,$brunei,$east-timor,$hong-kong,$indonesia,$japan,$macao,$malaysia,$singapore,$thailand,$botswana,$kenya,$lesotho,$mauritius,$mozambique,$namibia,$seychelles,$south-africa,$swaziland,$tanzania,$uganda,$zambia,$zimbabwe,$guyana,$suriname,$antigua-and-barbuda,$bahamas,$barbados,$jamaica,$australia-oceania" to_tag1="highway" to_value1="mini_roundabout" to_tag2="lhn" to_value2="yes" notosm="true"/>
- <entity_convert pattern="tag_transform" from_tag="highway" from_value="turning_loop" if_region_name="$cyprus,$malta,$gb,$ireland,$bangladesh,$bhutan,$india,$maldives,$nepal,$pakistan,$sri-lanka,$brunei,$east-timor,$hong-kong,$indonesia,$japan,$macao,$malaysia,$singapore,$thailand,$botswana,$kenya,$lesotho,$mauritius,$mozambique,$namibia,$seychelles,$south-africa,$swaziland,$tanzania,$uganda,$zambia,$zimbabwe,$guyana,$suriname,$antigua-and-barbuda,$bahamas,$barbados,$jamaica,$australia-oceania" to_tag1="highway" to_value1="mini_roundabout" to_tag2="lhn" to_value2="yes" notosm="true"/>
- <entity_convert pattern="tag_transform" from_tag="highway" from_value="turning_circle" if_region_name="$cyprus,$malta,$gb,$ireland,$bangladesh,$bhutan,$india,$maldives,$nepal,$pakistan,$sri-lanka,$brunei,$east-timor,$hong-kong,$indonesia,$japan,$macao,$malaysia,$singapore,$thailand,$botswana,$kenya,$lesotho,$mauritius,$mozambique,$namibia,$seychelles,$south-africa,$swaziland,$tanzania,$uganda,$zambia,$zimbabwe,$guyana,$suriname,$antigua-and-barbuda,$bahamas,$barbados,$jamaica,$australia-oceania" to_tag1="highway" to_value1="mini_roundabout" to_tag2="lhn" to_value2="yes" notosm="true"/> Assuming that every tag transform is checked in linear fashion, the effect should be that the mini_roundabout checking for lhn vs not lhn countries works after the turning_loop and turning_circle values are transformed to the mini_roundabout value. (But I'll confess that I haven't tested it.) |
Yes the order for changes is linear |
Turning circles in left-hand traffic countries (tested in New Zealand) show incorrect direction (counterclockwise) on the icon.
The text was updated successfully, but these errors were encountered: