Speed up tracks screen when no Smart Folders are used (partial fix for #17805) #19228
Conversation
|
Will there be any issues if we add new smart folders, but allAvailableTrackItems in SmartFolderHelper is empty? |
|
I have tested both creating a first smart folder and removing the last smart folder with that patch, and both worked apart from the slowness which returns then with the smartfolder code becoming active again, it seems. I think eventually we have to dig deeper to find a more complete solution here. As Victor said, neither reading 3500 file system line items to memory nor the creation of an (essentially empty) HashSet for the smart folders should really have to take as long as the app needs here... |
|
PS: When I have 1 (unfiltered) smart folder present and re-enter the Tracks screen, I can see that the app takes initially about 8 seconds to populate that smart folder (I can see the sub-header counting up), then about another 5 seconds to create the other (static) root folders (I have ~70). So with a smart folder I am back at the original 12-14 seconds... 😉 8 seconds to create a simple HashSet seems over the top? Or if that's what it takes then we should cache things? |
No description provided.