Test failure on 32 bit platforms

[tomhughes]

A number of the tests fail on a 32 bit platform with errors like this:

c++ -I../include -Iinclude -g -std=c++11 -Werror -Wall -Wextra -pedantic -Wredundant-decls -Wdisabled-optimization -Wctor-dtor-privacy -Wnon-virtual-dtor -Woverloaded-virtual -Wsign-promo -Wold-style-cast -o tests test_main.o t/basic/test_changeset.cpp
--------------------------
In file included from ../include/osmium/memory/collection.hpp:40:0,
                 from ../include/osmium/osm/changeset.hpp:39,
                 from t/basic/test_changeset.cpp:3:
../include/osmium/memory/item.hpp: In function 'osmium::memory::item_size_type osmium::memory::padded_length(osmium::memory::item_size_type)':
../include/osmium/memory/item.hpp:59:31: error: redefinition of 'osmium::memory::item_size_type osmium::memory::padded_length(osmium::memory::item_size_type)'
         inline item_size_type padded_length(item_size_type length) noexcept {
                               ^
../include/osmium/memory/item.hpp:55:23: error: 'size_t osmium::memory::padded_length(size_t)' previously defined here
         inline size_t padded_length(size_t length) noexcept {
                       ^

The problem is that on a 32 bit platform size_t is uint32_t and therefore the same as item_size_type and we wind up with duplicate function definitions.

[springmeyer]

Is 32 bit an important platform to run osmium on?

[tomhughes]

Well that's a reasonable question, but my problem is that I was considering packaging it for Fedora and 32 bit x86 and ARM are both primary architectures so any package would be expected to build there.

I could of course just not run the tests but that would probably only defer the problem until I tried to package something like osmium-tool or node-osmium that builds on top of libosmium.

[joto]

Compiling on 32bit should work now. @tomhughes can you verify?

[tomhughes]

Confirmed fixed.