Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of OsmBonusPack classes over to osmdroid #252

Closed
spyhunter99 opened this issue Jan 21, 2016 · 6 comments
Closed

Migration of OsmBonusPack classes over to osmdroid #252

spyhunter99 opened this issue Jan 21, 2016 · 6 comments

Comments

@spyhunter99
Copy link
Collaborator

MKergall/osmbonuspack#200 (comment)

after talking it over with @MKergall at OBP, sounds like we have concurrence to migrate the mentioned classes over to osmdroid. This will provide reduced complexity in osmdroid and reduce the somewhat cyclic dependency we have. OBP needs osmdroid, osmdroid deprecated PathOverlay saying to use OBP.

Anyhow this will be good for both projects

@spyhunter99
Copy link
Collaborator Author

merged

@MKergall
Copy link
Collaborator

You can remove all res/values directories => strings.xml only contains routing instructions, which are useless in osmdroid.

@MKergall
Copy link
Collaborator

In osmdroid/api, there are already a Marker and a Polyline class. They do nothing.
I don't know their purpose.
It can confuse to users, when using a Marker, to have to choose between "api" and "bonuspack" imports.
To be checked if they should be kept or not.

@spyhunter99
Copy link
Collaborator Author

the Marker class looks like an adapter for google maps via IMap which is "An interface that contains the common features of osmdroid and Google Maps v2. The marker class is used with the google wrapper only. Along with IMap and OnCameraChangeListener...

@spyhunter99
Copy link
Collaborator Author

i probably should have waited a bit to merge this. Although the code is there, it's not exactly integrated

spyhunter99 added a commit that referenced this issue Jan 30, 2016
@spyhunter99 spyhunter99 added this to the v6 milestone Feb 21, 2016
@spyhunter99 spyhunter99 mentioned this issue Feb 21, 2016
spyhunter99 added a commit that referenced this issue Apr 3, 2016
spyhunter99 added a commit that referenced this issue Apr 4, 2016
#252 javadocs
#259 removing deprecated class. it's been deprecated for at least 4 releases.
@spyhunter99
Copy link
Collaborator Author

@MKergall i shuffled a bunch of stuff around with commit 181d855

all of the OBP overlay classes were moved into org.osmdroid.views.overlay
cache manager went to org.osmdroid.tileprovider.cachemanager

more an an FYI than anything else and to help get the migration plan started

@spyhunter99 spyhunter99 modified the milestones: v6, v5.2 Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants