New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMercatorXFromLongitude signature mismatch #794

Closed
pasniak opened this Issue Nov 29, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@pasniak
Contributor

pasniak commented Nov 29, 2017

After code refresh to 0bad623 the build fails with

            final long left = TileSystem.getMercatorXFromLongitude(west, mapSize);
            final long top = TileSystem.getMercatorYFromLatitude(north, mapSize);
            final long right = TileSystem.getMercatorXFromLongitude(east, mapSize);
            final long bottom = TileSystem.getMercatorYFromLatitude(south, mapSize);

because of

public static long getMercatorXFromLongitude(final double pLongitude, final double pMapSize, boolean wrapEnabled)

[x] Build system related

Version of osmdroid the issue relates to:

6.0.0-SNAPSHOT

@pasniak

This comment has been minimized.

Show comment
Hide comment
@pasniak

pasniak Nov 29, 2017

Contributor

This test compilation error is due to commit c38260c by @Maradox

Contributor

pasniak commented Nov 29, 2017

This test compilation error is due to commit c38260c by @Maradox

@spyhunter99

This comment has been minimized.

Show comment
Hide comment
@spyhunter99

spyhunter99 Dec 2, 2017

Collaborator

Hmm travis has been building just fine. If you're building from source, you probably need to run gradle clean

Collaborator

spyhunter99 commented Dec 2, 2017

Hmm travis has been building just fine. If you're building from source, you probably need to run gradle clean

@spyhunter99

This comment has been minimized.

Show comment
Hide comment
@spyhunter99

spyhunter99 Dec 2, 2017

Collaborator

hmm this is rather sad, looks like gradlew connectedCheck only builds and runs android instrumentation tests and skips all junit tests, which means that our travis config is broken. This same signature mismatch causes the junit tests to fail to compile. ugh

Collaborator

spyhunter99 commented Dec 2, 2017

hmm this is rather sad, looks like gradlew connectedCheck only builds and runs android instrumentation tests and skips all junit tests, which means that our travis config is broken. This same signature mismatch causes the junit tests to fail to compile. ugh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment