Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvalidTagsRegexCheck - bad source #334

Closed
mm-ciub opened this issue Jul 27, 2020 · 0 comments · Fixed by #368
Closed

InvalidTagsRegexCheck - bad source #334

mm-ciub opened this issue Jul 27, 2020 · 0 comments · Fixed by #368
Labels
new integrity check Any new Integrity Check

Comments

@mm-ciub
Copy link
Contributor

mm-ciub commented Jul 27, 2020

Description
The InvalidTagsRegexCheck could have a similar approach as the InvalidTagsCheck but would use regex to verify certain tag values.
To begin with it should verify if the source tag describes a legal source of data imported in OSM.
Examples of invalid sources: Google, Here.

Requirements

  • Any OSM primitive that has a source tag should be feasible for this check.

Use Cases
There are multiple examples of cases where certain information in OSM comes from illegal sources like:

Example:

Case 1: [Cycleway originating from Google.] (Romania)

Case 2: [Park originating from Google.] (Italy)

Case 3: [Building originating from VWorld.] (South Korea)

Case 4: [Building originating from Here.] (Germany)

Further investigation

Supported regions
All regions should be supported.

What's not supported (optional):

References
https://wiki.openstreetmap.org/wiki/Key:source
https://wiki.openstreetmap.org/wiki/Tag:boundary=administrative

@mm-ciub mm-ciub added the new integrity check Any new Integrity Check label Jul 27, 2020
@sayas01 sayas01 added this to Backlog in Osmose Check Migration via automation Jul 27, 2020
@mm-ciub mm-ciub changed the title InvalidTagsCheck - bad source update InvalidTagsRegexCheck - bad source Jul 29, 2020
@sayas01 sayas01 linked a pull request Sep 8, 2020 that will close this issue
Osmose Check Migration automation moved this from Backlog to Released Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new integrity check Any new Integrity Check
Projects
1 participant