Construction check #358
Construction check #358
Conversation
| // 1 January 2020 | ||
| DateTimeFormatter.ofPattern("d MMMM yyyy")); | ||
| private static final LocalDate TODAYS_DATE = LocalDate.now(); | ||
| private static final List<String> DATE_TAGS = Arrays.asList("opening_date", "open_date", |
There was a problem hiding this comment.
It would be great if these could be added as tag classed here.
There was a problem hiding this comment.
Waiting on this: osmlab/atlas#679
There was a problem hiding this comment.
I didn't add "date_on" because it has no mention of it in the OSM wiki, should it still be included?
| private static final LocalDate TODAYS_DATE = LocalDate.now(); | ||
| private static final List<String> DATE_TAGS = Arrays.asList("opening_date", "open_date", | ||
| "construction:date", "temporary:date_on", "date_on"); | ||
| private static final List<String> CONSTRUCTION_TAGS = List.of("highway", "landuse", "building"); |
There was a problem hiding this comment.
| private static final List<String> CONSTRUCTION_TAGS = List.of("highway", "landuse", "building"); | |
| private static final List<String> CONSTRUCTION_TAGS = List.of(HighwayTag.KEY.toString(), LandUseTag.KEY.toString(), BuildingTag.KEY.toString()); |
| private boolean isConstruction(final Map<String, String> tags) | ||
| { | ||
| return tags.keySet().stream() | ||
| .anyMatch(tag -> tag.equals("construction") |
There was a problem hiding this comment.
| .anyMatch(tag -> tag.equals("construction") | |
| .anyMatch(tag -> tag.equals(ConstructionTag.KEY.toString()) |
or if you pass in the atlas object:
| .anyMatch(tag -> tag.equals("construction") | |
| .anyMatch(tag -> Validators.hasValueFor(object, ConstructionTag.class) |
| return Optional | ||
| .of(createFlag(object, this.getLocalizedInstruction(0, dateTag.get()))); |
There was a problem hiding this comment.
If the object is an Edge we will want to flag all the master edges with the same OSM ID (see InvalidTagsCheck for an example).
brianjor
force-pushed
the
construction-check
branch
from
df92d3f
to
9763668
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -189,6 +189,16 @@ | |||
| "tags": "highway" | |||
| } | |||
| }, | |||
| "ConstructionCheck": { | |||
| "oldConstructionDays": 730.0, | |||
There was a problem hiding this comment.
Just curious - whats the reasoning behind these values? Is 2 years a recommend length of time for checking these highways?
There was a problem hiding this comment.
Osmose uses 2 years as the limit for something to have been in construction when no date tags are available
https://github.com/osm-fr/osmose-backend/blob/master/plugins/Construction.py#L36
And the 6 month check_date was also from their check, though someone would have to update the check_date each time it gets flagged instead of marking as false positive:
https://github.com/osm-fr/osmose-backend/blob/master/plugins/Construction.py#L98
| * String representation of a date from a tag. | ||
| * @return the parsed date. | ||
| */ | ||
| private Optional<LocalDate> parseDate(final String tagDate) |
There was a problem hiding this comment.
This could be useful in atlas 😄
4070 ConstructionCheck
Description
This check checks if a features construction tag has not been updated for more than 2 years or the opening date has been exceeded.
Test Results
Yes, DMA did only have one flagged object.
Also tested on CMY but had no results.
Resolves #353