Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix Suggestions] Highway To Ferry Tag Check #396

Closed
ylinzhi opened this issue Oct 19, 2020 · 3 comments
Closed

[Fix Suggestions] Highway To Ferry Tag Check #396

ylinzhi opened this issue Oct 19, 2020 · 3 comments
Projects
Auto-fix Suggestions

Comments

@ylinzhi
Copy link
Contributor

ylinzhi commented Oct 19, 2020 •
edited
Loading

Which Atlas check is the fix suggestion related to?

Highway To Ferry Tag Check
Description: https://github.com/osmlab/atlas-checks/blob/6c987dd8bb0e87df4900e9a7a605f6a13ecfce7d/docs/checks/highwayToFerryTagCheck.md
Script: https://github.com/osmlab/atlas-checks/blob/6c987dd8bb0e87df4900e9a7a605f6a13ecfce7d/src/main/java/org/openstreetmap/atlas/checks/validation/tag/HighwayToFerryTagCheck.java

Describe more details of suggested fix(es)

Suggested Fix 1:

  • Type of fixing: Tag fix

  • Operation: Modify

  • Suggested Action: Change the highway=* tag to ferry=* tag that aligns with the classification of connected highways

Is there any code enhancement needed if adding the fix suggestion component?

No
@sayas01 sayas01 added this to To do in Auto-fix Suggestions via automation Oct 19, 2020
@Bentleysb
Copy link
Collaborator

👍

@mm-ciub mm-ciub mentioned this issue Mar 4, 2021
Merged
dcastrowa pushed a commit that referenced this issue Mar 10, 2021
@mm-ciub
#396 HighwayToFerryTagCheck fix suggestions (#524)
81e3bb3 
* Added fix suggestion for HighwayToFerryTagCheck

- implemented
- added new verifiers for this in existing unit tests

* Changed complete entity to shallow version with tags

* Extended fix suggestion to all edges
@mm-ciub
Copy link
Contributor

mm-ciub commented Mar 16, 2021

I believe this issue can be closed now.

@Bentleysb
Copy link
Collaborator

Complete

Auto-fix Suggestions automation moved this from To do to Done Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Auto-fix Suggestions
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bentleysb @ylinzhi @mm-ciub