added about page, descriptions on survey page, and content on about page #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felskia
commented
Sep 27, 2017
src/ui/about/index.jsx
Outdated
| </section> | ||
| <section className='row section__about'> | ||
| <h3>Getting Started</h3> | ||
| <p>The Observe App comes pre-filled with the standard OSM survey from the iD Editor. This means you don't need to create a custom survey before you can start making observations that can upload to OSM. To upload new surveys, locate the survey YAML file on your local hard drive. Find more information about how to create your own survey <a className='link--primary link--lowercase' href="https://github.com/osmlab/field-data-collection/blob/master/docs/surveys.md">here</a>.</p> |
There was a problem hiding this comment.
@dereklieu this link needs to like to a normal browser window
felskia
commented
Sep 27, 2017
src/ui/surveys/Import.jsx
Outdated
| @@ -12,7 +13,7 @@ class Import extends React.Component { | |||
| return ( | |||
| <div className='surveyInput'> | |||
| <h3 className='withDescription'>Add new survey details</h3> | |||
| <p className='description'>Description of how to add things. Find more information about how to make a survey file here.</p> | |||
| <p className='description'>Only surveys that are in a YAML format can be imported. More information on how to format or modify an existing YAML file can be found on the <Link to='/about' className='link--primary link--lowercase'>about page</Link> or <a className='link--primary link--lowercase' href="https://github.com/osmlab/field-data-collection/blob/master/docs/surveys.md">here</a>.</p> | |||
There was a problem hiding this comment.
@dereklieu same with this one here. :)
|
Thanks @felskia, I added a snippet to open links in your default browser. |
dereklieu
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.