-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop suggesting some amenity=fuel names #29
Comments
I think for these it's common to use the brand name as the common name that people refer to the place. We should fill in |
It's common because people don't understand |
People also wrongly use |
This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand. |
Can you link to a node where iD shows a warning? |
Here's one: https://www.openstreetmap.org/node/2849420428 The default behaviour is definitely wrong.
|
This node was originally tagged |
iD should not remove the name, but it also should not pop up a warning if the name field is empty and, worse, fill it with the brand.
|
@AntMadeira I hear what you're saying, but I'm having a hard time seeing how You can change the name to whatever you want, but the gas station should have some name right? People who use maps expect the markers to be labeled with something. |
I have to agree with @bhousel on this one. OSM is full of gas stations with no names that don't display correctly and it's really problematic. If a gas station has a non brand name that should be set but the brand is better than no name at all. |
Not every element as name, for the most various reasons. Usually, a fuel station has a name, but you may not fill it because you didn't notice it, hadn't time to right it down, etc. If you're "forcing" people to apply a name, that's worse than having no name at all. Apps show fuel stations as POI, even if there's no name present. The brand will show, and the name will also show if it exists, not because iD decided it should exist. I think the wiki is very helpful on this: |
It seems that the some
amenity=fuel
names shouldn't be suggested at all.For example, right now we have in OSM 8615 objects with
brand=Shell
and 10228 objects withname=Shell
Most probably people are wrongly using
brand
asname
since the default OSM style doesn't display thebrand
gravitystorm/openstreetmap-carto#1874 (ie, users are tagging for the renderer).Suggesting such names that clearly are
brand
will just keep feeding the wrong names.The text was updated successfully, but these errors were encountered: