Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop suggesting some amenity=fuel names #29

Closed
naoliv opened this issue Dec 4, 2015 · 14 comments
Closed

Stop suggesting some amenity=fuel names #29

naoliv opened this issue Dec 4, 2015 · 14 comments

Comments

@naoliv
Copy link
Contributor

naoliv commented Dec 4, 2015

It seems that the some amenity=fuel names shouldn't be suggested at all.
For example, right now we have in OSM 8615 objects with brand=Shell and 10228 objects with name=Shell

Most probably people are wrongly using brand as name since the default OSM style doesn't display the brand gravitystorm/openstreetmap-carto#1874 (ie, users are tagging for the renderer).

Suggesting such names that clearly are brand will just keep feeding the wrong names.

@bhousel
Copy link
Member

bhousel commented Oct 3, 2017

I think for these it's common to use the brand name as the common name that people refer to the place.

We should fill in name and brand and brand:wikidata, which is what #38 is about

@bhousel bhousel closed this as completed Oct 3, 2017
@naoliv
Copy link
Contributor Author

naoliv commented Oct 3, 2017

It's common because people don't understand brand + the editor also suggests to wrongly use brand in name.

@naoliv
Copy link
Contributor Author

naoliv commented Oct 3, 2017

People also wrongly use brand in name because of this gravitystorm/openstreetmap-carto#1874 for example
In some place we need to stop suggesting brand names in name (and this should be in the editors).

@AntMadeira
Copy link

This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand.
Please, correct this, because it's filling the database with wrong names.

@bhousel
Copy link
Member

bhousel commented Oct 31, 2021

This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand.
Please, correct this, because it's filling the database with wrong names.

Can you link to a node where iD shows a warning?
AFAIK if the user picks the "Shell" preset when creating a new gas station, it will default it brand=Shell and name=Shell (which is definitely not wrong), and mappers are free to change the name to something else like name=Shell - Morristown, and iD should preserve the name tag and not raise a warning about it.

@AntMadeira
Copy link

Here's one: https://www.openstreetmap.org/node/2849420428

The default behaviour is definitely wrong. brand is different from name and iD should not promote this.
Even if the name can coincide with the brand, many times, the fuel station has a brand and a specific name, and if iD fills the name automatically, it is populating the database with wrong and meaningless data. For example, in Brazil, almost all fuel stations have a name, different from the brand. New mappers are encouraged to apply these warnings without knowing this is not right.

This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand.
Please, correct this, because it's filling the database with wrong names.

Can you link to a node where iD shows a warning? AFAIK if the user picks the "Shell" preset when creating a new gas station, it will default it brand=Shell and name=Shell (which is definitely not wrong), and mappers are free to change the name to something else like name=Shell - Morristown, and iD should preserve the name tag and not raise a warning about it.

@bhousel
Copy link
Member

bhousel commented Oct 31, 2021

This is the warning I see.. It's prompting me to update the brand tags, but I can set the name to whatever I want:

Screen Shot 2021-10-31 at 12 08 30 PM

If I choose to upgrade it, I get this - that's what you want yes?

Screen Shot 2021-10-31 at 12 10 16 PM

@1ec5
Copy link
Member

1ec5 commented Oct 31, 2021

Here's one: https://www.openstreetmap.org/node/2849420428

This node was originally tagged name=GALP a long time ago, manually, before the NSI-based validator was ever implemented. Later, it was tagged brand=GALP manually using OsmAnd. Were you expecting iD to automatically remove the name from the node when you recently used iD to add the brand:wikidata and brand:wikipedia tags?

@AntMadeira
Copy link

The problem is when you don't fill the name field. The warning still pops up.
If you don't know the name and the brand is correct, iD should not show the warning and should not fill the name field with the brand.

If I choose to upgrade it, I get this - that's what you want yes?

Screen Shot 2021-10-31 at 12 10 16 PM

@AntMadeira
Copy link

iD should not remove the name, but it also should not pop up a warning if the name field is empty and, worse, fill it with the brand.

Here's one: https://www.openstreetmap.org/node/2849420428

This node was originally tagged name=GALP a long time ago, manually, before the NSI-based validator was ever implemented. Later, it was tagged brand=GALP manually using OsmAnd. Were you expecting iD to automatically remove the name from the node when you recently used iD to add the brand:wikidata and brand:wikipedia tags?

@AntMadeira
Copy link

In short, this suggestion should not be made:
firefox_b8hzXlHobo

@bhousel
Copy link
Member

bhousel commented Oct 31, 2021

@AntMadeira I hear what you're saying, but I'm having a hard time seeing how name=GALP is worse than having no name at all. I really feel like most people would feel oppositely.

You can change the name to whatever you want, but the gas station should have some name right? People who use maps expect the markers to be labeled with something.

@tas50
Copy link
Contributor

tas50 commented Oct 31, 2021

I have to agree with @bhousel on this one. OSM is full of gas stations with no names that don't display correctly and it's really problematic. If a gas station has a non brand name that should be set but the brand is better than no name at all.

@AntMadeira
Copy link

Not every element as name, for the most various reasons. Usually, a fuel station has a name, but you may not fill it because you didn't notice it, hadn't time to right it down, etc. If you're "forcing" people to apply a name, that's worse than having no name at all. Apps show fuel stations as POI, even if there's no name present. The brand will show, and the name will also show if it exists, not because iD decided it should exist.

I think the wiki is very helpful on this:
https://wiki.openstreetmap.org/wiki/Names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants