Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Edgars women's clothing store #3200

Closed
tas50 opened this issue Oct 29, 2019 · 7 comments
Closed

Add Edgars women's clothing store #3200

tas50 opened this issue Oct 29, 2019 · 7 comments
Labels
check local This issue should be checked with the local mapping community for guidance question Not Actionable - just a question about something

Comments

@tas50
Copy link
Contributor

tas50 commented Oct 29, 2019

Women's clothing store: https://www.edgars.co.za
@tas50 tas50 added add brand Actionable - add a brand to the index Hacktoberfest labels Oct 29, 2019
@m4tr1k
Copy link

m4tr1k commented Oct 29, 2019

@tas50 can I take this one?

@tas50
Copy link
Contributor Author

tas50 commented Oct 29, 2019

@m4tr1k all yours

@m4tr1k
Copy link

m4tr1k commented Oct 30, 2019

@tas50 it is already on the json file, so I don't think this issue is necessary
image
I will try another issue!

@mds08011 mds08011 added needs wikidata It is necessary to create a wikidata entry and removed add brand Actionable - add a brand to the index labels Oct 30, 2019
@Adamant36
Copy link
Collaborator

@m4tr1k you can still create a Wikidata entry for it and do a PR with that. If you need any help let us know.

@Adamant36
Copy link
Collaborator

@tas50, it says on their website that they have all kinds of stuff. Including men's clothing, beauty products, and housewares. Are you sure they wouldn't be better tagged as a department store like ROSS or TJ-Max?

@UKChris-osm
Copy link
Collaborator

I see that Edgars has Wiki* data added to it now, and almost all entries in OSM are tagged as a clothes shop, so can this be closed, or should it be updated to be tagged as a department store?

It does seem like it's more of a department store, but the very high number of clothes shop tags makes me wonder if local people are happier with that tag?

@UKChris-osm UKChris-osm added check local This issue should be checked with the local mapping community for guidance question Not Actionable - just a question about something and removed needs wikidata It is necessary to create a wikidata entry labels Nov 16, 2020
@bhousel
Copy link
Member

bhousel commented Nov 19, 2020

It does seem like it's more of a department store, but the very high number of clothes shop tags makes me wonder if local people are happier with that tag?

Oh interesting - yeah I agree it should be a department_store. We should probably change it in the NSI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
check local This issue should be checked with the local mapping community for guidance question Not Actionable - just a question about something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bhousel @tas50 @mds08011 @m4tr1k @Adamant36 @UKChris-osm