Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include route_master relations in validation #5184

Closed
kjonosm opened this issue Aug 2, 2021 · 5 comments · Fixed by openstreetmap/iD#8627
Closed

Include route_master relations in validation #5184

kjonosm opened this issue Aug 2, 2021 · 5 comments · Fixed by openstreetmap/iD#8627
Labels
considering Not Actionable - still considering if this is something we want

Comments

@kjonosm
Copy link
Collaborator

kjonosm commented Aug 2, 2021

Maybe an iD issue? iD now checks for incomplete or inconsistent tagging of route relations. Unfortunately this check doesn't seem to also cover the corresponding parent route_master relations. Is there a way to also include those when validating?

@bhousel
Copy link
Member

bhousel commented Aug 2, 2021

Oh interesting - yes that might go here. I hadn't thought about adding items for the route_master relations before, and my impression was that they are kind of rare. e.g. we would not want to auto-generate a route_master for every route=*.

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Aug 2, 2021
@kjonosm
Copy link
Collaborator Author

kjonosm commented Aug 2, 2021

On a quick look, I'd say they are in widespread use - in Germany anyway. Nearly all two way routes have a corresponding route_master.

You might want to have a look at https://ptna.openstreetmap.de a qa tool with lots of checks used in quite a few countries. The problem described above has prompted validation errors over there.

@osm-ToniE
Copy link

@bhousel

e.g. we would not want to auto-generate a route_master for every route=*.

Oh no, the issue is just that the 'network' tag of an existing route_master differs from the 'network' tag of the route members after the changes.

Example: https://ptna.openstreetmap.de/results/DE/NW/DE-NW-AVV-Analysis.html#bus_234

Do not auto-create route_masters, that doesn't make sense.

@bhousel
Copy link
Member

bhousel commented Aug 3, 2021

Do not auto-create route_masters, that doesn't make sense.

Yes I agree! But I think I can add something on the iD side so that if it sees a route_master, it can just treat it like a route.

@osm-ToniE
Copy link

Yeah would be great to have this ASAP, number of problematic cases is exploding now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants