Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name= on amenity_parcel_locker #6979

Closed
coolultra1 opened this issue Aug 28, 2022 · 5 comments
Closed

name= on amenity_parcel_locker #6979

coolultra1 opened this issue Aug 28, 2022 · 5 comments
Labels
considering Not Actionable - still considering if this is something we want

Comments

@coolultra1
Copy link
Contributor

Hi,

It seems to me, some templates for parcel lockers include a name= tag, some don't. The tag is generally unneccessary as the name that's rendered on Carto, for instance is the brand= tag. How about removing all name= from amenity=parcel_lockers, then?

@arch0345 arch0345 added the considering Not Actionable - still considering if this is something we want label Aug 28, 2022
@hanchao
Copy link
Collaborator

hanchao commented Aug 29, 2022

The labeling logic has not changed, it still use name.
gravitystorm/openstreetmap-carto#4512 (review)
https://github.com/gravitystorm/openstreetmap-carto/blob/master/style/amenity-points.mss#L2970

@coolultra1
Copy link
Contributor Author

coolultra1 commented Aug 29, 2022

Though, for some reason, brand is (also??) rendered https://www.openstreetmap.org/node/9071299691

@hanchao
Copy link
Collaborator

hanchao commented Aug 31, 2022

Though, for some reason, brand is (also??) rendered https://www.openstreetmap.org/node/9071299691

This is a good case. My mistake.
When importing data, use the brand first
https://github.com/gravitystorm/openstreetmap-carto/blob/master/project.mml#L1490

@kjonosm
Copy link
Collaborator

kjonosm commented Sep 3, 2022

We could also add "preserveTags": ["^name"] to the general properties in the file, see e.g. bicycle_rental.json for reference.

@hanchao
Copy link
Collaborator

hanchao commented Sep 20, 2022

I added "preserveTags": ["^name"] to the amenity/parcel_locker in 5876cc4

This will allow the name tag as an initial value, but users are encouraged to change it, and NSI will not overwrite the custom names that people add.

Alse see the discussion by @bhousel in #4985

@hanchao hanchao closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants