Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charging_station.json #4985

Closed
wants to merge 1 commit into from

Conversation

kjonosm
Copy link
Collaborator

@kjonosm kjonosm commented Mar 20, 2021

Delete name tag for charging stations.
According to OSM wiki it should not be used in that context.
There seems no information gain as name just duplicates the operator value.

Delete name tag for charging stations
@LaoshuBaby
Copy link
Collaborator

LaoshuBaby commented Mar 20, 2021 via email

@bhousel
Copy link
Member

bhousel commented Mar 20, 2021

Yeah I agree with @LaoshuBaby , I think it's ok to leave name here as an initial seed value, and I'm not comfortable just removing them all.

I also don't think the wiki really says not to use names, and if it did, I would maybe check the page history and question who wrote that. I think it's reasonable to expect renderers to use name tag for displaying labels on map pins.

  • If a user adds a charging station named "ChargePoint" that is ok. As far as I can tell, they don't have unique names.
  • Some brands like "Tesla Supercharger" do seem to have unique names for the charging stations?
  • We can add a "preserveTags": ["^name"] property either to individual items, or to the category as a whole, so that the name won't be overridden if a user wants to rename it to something else. (This makes them like Amazon Lockers)

(I need to add some better guidance around name to our project documentation. How we work with the name tag has evolved since #4906 and that's only within the past month).

@LaoshuBaby
Copy link
Collaborator

LaoshuBaby commented Mar 20, 2021 via email

@kjonosm
Copy link
Collaborator Author

kjonosm commented Mar 20, 2021

If a user adds a charging station named "ChargePoint" that is ok. As far as I can tell, they don't have unique names.
Some brands like "Tesla Supercharger" do seem to have unique names for the charging stations?

Tesla Superchargers seem to have a unique name, see their website

image

@kjonosm
Copy link
Collaborator Author

kjonosm commented Mar 20, 2021

I also don't think the wiki really says not to use names, and if it did, I would maybe check the page history and question who wrote that.

I wasn't precise on this. The wiki doesn't recommend not to use name. It rather doesn't mention the name tag at all.

@kjonosm
Copy link
Collaborator Author

kjonosm commented Mar 20, 2021

Fastned, another European charging station operator also uses unique names for their stations, see their website

image

@bhousel bhousel closed this in 57aba8b Mar 21, 2021
@bhousel
Copy link
Member

bhousel commented Mar 21, 2021

I added "preserveTags": ["^name"] to the operators/amenity/charging_station category in 57aba8b ..

This will allow the name tag as an initial value, but users are encouraged to change it, and NSI will not overwrite the custom names that people add.

@LaoshuBaby LaoshuBaby mentioned this pull request Apr 6, 2021
@arch0345 arch0345 mentioned this pull request Sep 19, 2021
@arch0345 arch0345 deleted the Delete-name-tag-for-charging-stations branch November 3, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants