-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update charging_station.json #4985
Conversation
Delete name tag for charging stations
According to the OSM Wiki https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcharging_station#Examples
Yes, name is sometimes not needed, but if you don't offer a default name, mapper will have to write it manually. And when render, it will also looking for ```name``` key.
And the data now existing is have name, for example https://github.com/osmlab/name-suggestion-index/blob/main/data/operators/amenity/charging_station.json#L2749
If a charging_station have a special name, not the name heritaged from the brand, I guess edit it when mapping is a better way, and let more mapper can auto input the default name of this brand
…------------------ Original ------------------
From: ***@***.***>;
Date: 2021年3月20日(星期六) 晚上9:53
To: ***@***.***>;
Cc: ***@***.***>;
Subject: [osmlab/name-suggestion-index] Update charging_station.json (#4985)
Delete name tag for charging stations.
According to OSM wiki it should not be used in that context.
There seems no information gain as name just duplicates the operator value.
You can view, comment on, or merge this pull request online at:
#4985
Commit Summary
Update charging_station.json
File Changes
M data/operators/amenity/charging_station.json (32)
Patch Links:
https://github.com/osmlab/name-suggestion-index/pull/4985.patch
https://github.com/osmlab/name-suggestion-index/pull/4985.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Yeah I agree with @LaoshuBaby , I think it's ok to leave I also don't think the wiki really says not to use names, and if it did, I would maybe check the page history and question who wrote that. I think it's reasonable to expect renderers to use
(I need to add some better guidance around |
ahh……
here are some experience about the ration between individual point and chain brand
some times we mapper at china ,when we add a new point, especially it is a bank or telecommunication office, there will be a ref name called “'XXX支行”/“'XXX分理处” like
if we know the ref/alias of this individual point, we will manualy change the key name to “'XX银行 - XXX支行”,but if we don't know we will use the default suggested name instead because at least we should render a name to let people can see this point belongs to which brand.
for another PR i just merged is because I think at that scenario, single sharing station will be in a network and have special ref name.
but those commcial charging station, the different between brand may large, so i think the name should show this difference.
…---Original---
From: "Bryan ***@***.***>
Date: Sun, Mar 21, 2021 01:25 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [osmlab/name-suggestion-index] Update charging_station.json (#4985)
Yeah I agree with @LaoshuBaby , I think it's ok to leave name here as an initial seed value, and I'm not comfortable just removing them all.
I also don't think the wiki really says not to use names, and if it did, I would maybe check the page history and question who wrote that. I think it's reasonable to expect renderers to use name tag for displaying labels on map pins.
If a user adds a charging station named "ChargePoint" that is ok. As far as I can tell, they don't have unique names.
Some brands like "Tesla Supercharger" do seem to have unique names for the charging stations?
We can add a "preserveTags": ["^name"] property either to individual items, or to the category as a whole, so that the name won't be overridden if a user wants to rename it to something else.
(I need to add some better guidance around name to our project documentation. How we work with the name tag has evolved since #4906 and that's only within the past month).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Tesla Superchargers seem to have a unique name, see their website |
I wasn't precise on this. The wiki doesn't recommend not to use |
Fastned, another European charging station operator also uses unique names for their stations, see their website |
I added This will allow the |
Delete
name
tag for charging stations.According to OSM wiki it should not be used in that context.
There seems no information gain as
name
just duplicates theoperator
value.