New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should temporary brand logo changes be ignored? #8373
Comments
This happens occasionally with high-profile brands: openstreetmap/iD#6361 #2798 #3122 #8042. The best we’ve come up with so far has been to hard-code a list of brands that always get a logo from Commons via Wikidata, which would work for McDonald’s too: name-suggestion-index/scripts/dist_files.js Lines 287 to 294 in 21597bd
I guess we could’ve foreseen Grimace’s birthday plans based on the controversy on Fandom. But overall, this is a pretty reactive approach to mitigating against social media cheekiness. By the time we fix it, the campaign is already over. I don’t know how the social media managers would feel about knowing their hijinks show up in such a different context.
Caching Facebook or Twitter profile photos en masse would definitely be a copyright issue. Fetching more logos from Commons was considered in #2641, but the concern then was that many of the logos were the wrong aspect ratio or format, and that filtering candidate Commons images was too much work for too little gain. Let’s just hope Grimace doesn’t inspire more copycats in the hamburglar joint industry. |
Has any brand ever contacted NSI in any way? Caching logos may (or may not) be an issue legally, but I doubt it'd be an issue in reality. However even if we decided we wanted to cache/pin logos, it may be an issue with time/maintainability. |
I didn't know how the Facebook logos worked, so I just looked. We have |
More precisely, the fact that we aren’t redistributing the logos mitigates concerns about copyright infringement: openstreetmap/iD#5167. That said, proxying the APIs has been floated in the past as a mitigation for privacy concerns: openstreetmap/iD#7028. The terms-of-service implications of either step are unclear to me. If proxying is OK then maybe caching would be too, but this is a lot of complexity compared to, say, fetching more logos from Commons. |
The raw url has a time in it, so will expire soon, so we can't cache the URLs.
Commons makes it clear they don't want (most) logos. And relying on it for more logos will lead to the opposite problem: us having old logos. I think that'd annoy brands more than caching logos. And there is the possibility of malicious edits to Wikidata. Adding McDonalds to |
Hosting a private copy of the logos is the route I took for my app. Sites like If you read this article (scroll down to the section titled “Fair Use of Logos”) it seems that hosting the logo should be fair use:
|
I'm getting a little off topic, but |
What you were hearing about the Commons route was misinformed. Commons only stores the images. It’s Wikidata itself that maps items to logos, and we’re already using it for quite a few NSI entries, especially in the transit tree, just not preferring it over Facebook and Twitter. When Commons can’t cover the latest logo design over copyright concerns, Wikidata says so (novalue or somevalue). |
I know Wikidata links to Commons. I should have been clearer in that comment. I don't know of another service (that will host logos) that can be linked with Wikidata, either Wikidata linking to it, or it linking to Wikidata. |
It seems that the original problem has been solved (oh no, not a solution, only a workaround) I added it, so I close this issue, but looks like discussion on how to solve still continue, about copyright or about a threshold? |
Hey this is cool and I didn't know about it - I'll open a separate issue to see whether we can just use this result instead of actually fetching the image. IIRC, the main reason for fetching the Facebook image was these lines of code to determine whether the result actually has a logo or returns a question mark placeholder image. #2750 name-suggestion-index/scripts/build_wikidata.js Lines 609 to 611 in 5dddc11
But I see the graph api does return a property like |
Oh and about this issue - I am pretty ok with just updating the name-suggestion-index/scripts/dist_files.js Lines 287 to 296 in 5dddc11
I understand that for some apps it might make sense to download and cache all the logos, or to try to build something special to try to work around this issue, but I just don't see this as an important enough problem to spend development time on right now. It would be awesome if all the logos were public domain or in Commons, but we don't have that. If someone wants to make another project that just takes all the logo URLs that NSI has gathered, and saves those files somewhere, and it turns out to be helpful to someone, then yeah someone can build and maintain that. 👍 |
Recently, some editors from China (not me) noticed that McDonald's logo has turned into a purple monster(?), thinking that the data in OSM maybe affected or linked wrong, linked to another wikidata, but after my research found that it was actually because McDonald's (US business department?) changed Twitter and Facebook's avatar to promote their new campaign.
For regions that have these events - people obviously easy to spot and even feel surprise(?), but for regions that don't, does a change to the very familiar logo make editors wonder Puzzled. (For example, at least in Greater China, I have never heard of it)
I know it's not NSI's fault - it's just very faithfully scraping the Twitter/Facebook avatar data from Wikidata - and showing it, but I wonder if there is a way for us to avoid this abrupt change, for example setup a cache? (But I think there must be a copyright issue)
The text was updated successfully, but these errors were encountered: