Add the type of trade to Jewson's (and others) as part of #4140

[peternewman]

Add the inevitable matchname too and some matchtags

[bhousel]

Looks ok to me, thanks 👍

The matchTags for shop/doityourself is a good suggestion, but it will get removed as redundant when I run the build script.

This is because of "match groups" - see:
https://github.com/osmlab/name-suggestion-index/blob/main/config/match_groups.json
Tags in a match group will automatically match any other tags in the same match group.

[peternewman]

The matchTags for shop/doityourself is a good suggestion, but it will get removed as redundant when I run the build script.

This is because of "match groups" - see:
https://github.com/osmlab/name-suggestion-index/blob/main/config/match_groups.json
Tags in a match group will automatically match any other tags in the same match group.

Ah I did ponder them, but didn't go looking for them. Can the match groups handle shop=trade being in multiple match groups? Wholesale should probably have it for the catering supplies aspect for example.
https://wiki.openstreetmap.org/wiki/Tag:shop=trade

[bhousel]

Ah I did ponder them, but didn't go looking for them. Can the match groups handle shop=trade being in multiple match groups? Wholesale should probably have it for the catering supplies aspect for example.

Yes the matcher code does allow a tagpair to be in to multiple match groups.

For example, shop=wholesale is in a few match groups. This means that if a wholesaler like Costco is mistagged as shop=supermarket or shop=department_store or shop=food it will still be matched, and the iD validator will suggest it to be tagged as shop=wholesale to match the NSI.