Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display existing notes #55

Closed
pyrog opened this issue Mar 8, 2017 · 7 comments
Closed

Display existing notes #55

pyrog opened this issue Mar 8, 2017 · 7 comments

Comments

@pyrog
Copy link

pyrog commented Mar 8, 2017

It's not possible to see If other users have already created notes in the aerea.

Could be fine to display notes created by onosm.org ?

@iandees
Copy link
Member

iandees commented Mar 8, 2017

The users submitting information shouldn't be bothered with existing notes, but I can see that it would be helpful for OSM mappers to see the notes that onosm.org created on an overview map or something.

@pyrog
Copy link
Author

pyrog commented Mar 8, 2017

Are they really bothered if we display only notes created by onosm ?
They could see that somebody have "create" the same business before 😉

@stevevance
Copy link

stevevance commented Mar 8, 2017

I think the purpose is to get businesses, who likely know nothing about OSM, to submit their business. Showing any other information, like if their business has been submitted before, would be a distraction to that process.

I don't think there's a concern that a business will be submitted more than once through this interface. An experienced OSM mapper will add it directly. The other competition for adding businesses via notes is the (wonderful) Maps.me app, but even if a business shows up 2x, one from each source (onosm and Maps.me), that's a problem I'd like to have because it probably means two people are interacting with OSM instead of one person. (And it could also mean that two people are providing different information, which could enhance the info we receive about that business.)

@alexandre-mbm
Copy link
Contributor

It will is problematic if onosm become much known.

@ENT8R
Copy link

ENT8R commented Jun 7, 2018

but I can see that it would be helpful for OSM mappers to see the notes that onosm.org created on an overview map or something

I created a tool for that some time ago:

To show the last 100 notes created by onosm.org on a map:
https://ent8r.github.io/NotesReview/?query=onosm.org&limit=100&start=true

To show the last 100 notes created by onosm.org in a list:
https://ent8r.github.io/NotesReview/expert/?query=onosm.org&limit=100&start=true

I used my tool to resolve some notes created by this website and I never encountered notes which referenced the same business twice...

@hashtagdeamon
Copy link
Contributor

@iandees
Copy link
Member

iandees commented Jul 20, 2018

I'm not going to display existing notes. That complicates the process.

The problem of "exact" duplicates is different. I disagree that it's the client's responsibility to avoid duplicates. If OSM cares enough about preventing duplicates, it should prevent duplicates on the server side. That being said, onosm can do some client-side work to try and prevent it: my guess is people are double-clicking the button in the final step. I can open a new ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants