Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallowing the creation of duplicate notes #1929

Closed
hashtagdeamon opened this issue Jul 19, 2018 · 2 comments
Closed

Disallowing the creation of duplicate notes #1929

hashtagdeamon opened this issue Jul 19, 2018 · 2 comments

Comments

@hashtagdeamon
Copy link

I propose to implement a check before a note is added to the database to avoid duplicate notes. By "duplicate note" I mean two notes (A and B) with A already in the database and B to be created with the following properties:

  • A's comment = B's comment (possibly ignoring capitalization)
  • A's position (lat, lon) = B's position

There is no reason for a second note B to be added to the database. The osm-wiki's guidelines allow/suggest to close B right away anyway. But as there are more than 10000 such notes in the db already and there are constantly new ones created, I suggest a check as part of the API/website.

This would mostly affect maps.me, but as it is a general issue and maps.me itself has proven to be unable to fix it (mapsme issue #4663), I suggest a change on this side now.

@tomhughes
Copy link
Member

This sounds like a ridiculous workaround for a bug that clearly lies somewhere else.

In the real world nobody is ever going to add a second note with both text and location that is an exact match so clearly this is a broken automated process somewhere and that is what should be fixed.

@hashtagdeamon
Copy link
Author

Top 20 open duplicates which are not from maps.me:
540985
540995
936047
937205
1175542
729936
500717
571763
754249
754267
754247
754265
754245
754263
754244
754262
754243
754261
754242
754260
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@tomhughes @hashtagdeamon and others