Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When bounds are given, whole planet is queried anyway - this is slow. #49

Closed
Piskvor opened this issue Jan 19, 2017 · 3 comments
Closed

Comments

@Piskvor
Copy link
Contributor

Piskvor commented Jan 19, 2017

Even if a bounding box is requested through the #bounds= parameter, the query for updates still loads the whole planet's changes and parses that. A single update could be multiple MBs, most of which is thrown away - on a bad connection, this is especially palpable.

If a bounding box exists, updates should be polite and use it.

@iandees
Copy link
Member

iandees commented Jan 19, 2017

Last I checked the augmented diffs thing didn't support bounding box queries (even though it said it did 😄 ). That was a while ago, though, so maybe it has been fixed.

@Piskvor
Copy link
Contributor Author

Piskvor commented Jan 19, 2017

It has. PR forthcoming :)

@Piskvor
Copy link
Contributor Author

Piskvor commented Jan 20, 2017

Alas, we were both right. Bounding box queries are supported, but somewhat-silently fail on large bboxes. #50 doesn't work for e.g. country-sized bbox; I propose a dumb - and perhaps overcautious - heuristic for the filtering: #52 . (Testing with larger bboxes gave me very long response times (80 seconds for a 60-second update cycle), which might be equally uncomfortable to the user and Overpass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants