Check if the bounding box size is acceptable to Overpass for filtering: #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requesting a too-large area will result in an empty response, or one that takes way too long. Therefore, guess at area size which can be filtered within reasonable time (2 degrees square, currently). If the bounding box is larger, fall back: request changes for the whole planet and process them client-side - even though it consumes more bandwidth, this is a pre-generated file, thus lower server load.
Piskvor
commented
Jan 20, 2017
| @@ -52,7 +55,8 @@ var overview_map = L.map('overview_map', { | |||
| touchZoom: false, | |||
| scrollWheelZoom: false, | |||
| doubleClickZoom: false, | |||
| boxZoom: false | |||
| boxZoom: false, | |||
| minZoom: 4 | |||
There was a problem hiding this comment.
A general fix for "loading a large bbox attempts to load an overview map which is zoomed out too much, which also fails". This will force-set the zoom to the minimum, avoiding the issue.
Piskvor
commented
Jan 20, 2017
| // A guesstimate of the maximum filtered area size that the server would accept. | ||
| // For larger areas, we fall back to the global (server-cached) change file | ||
| // ...and we process it client-side as usual. | ||
| return (width * height) < 2; |
There was a problem hiding this comment.
This is only enforced as a hard limit here - e.g. "3" also kind of works - but I don't want to load the Overpass server too much
|
Thanks again for your contributions! |
|
You're welcome. I'm essentially scratching my own itches - in a mapathon, the issues addressed by the PRs were friction points for us :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requesting a too-large area will result in an empty response,
or one that takes way too long. Therefore, guess at area size
which can be filtered within reasonable time (2 degrees square, currently).
If the bounding box is larger, fall back: request changes for the whole planet
and process them client-side - even though it consumes more bandwidth,
this is a pre-generated file, thus lower server load.