Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mergify config #168

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Conversation

alexanderbez
Copy link
Collaborator

Description

Closes: #143

Updated the automerge and backporting configurations


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding these configs

Had 2 questions about whether we want to backport to earlier branches and the right use of v0.45.0x-osmo-v8

branches:
- v0.45.0x-osmo-v7

- name: backport patches to v0.45.0x-osmo-v8 branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: should we be using this tag before v9 is released? My understanding is that we would start using v0.45.0x-osmo-v8 once v8 is released

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already existed in the config so I just updated it here. Also, v0.45.0x-osmo-v8 already exists.

.mergify.yml Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 14651aa into osmosis-main Mar 30, 2022
@alexanderbez alexanderbez deleted the bez/mergify-updates branch March 30, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up mergify in cosmos-sdk fork
2 participants