feat!: support for custom proposal-based voting periods #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will fix tests shortly. |
mattverse
approved these changes
May 20, 2022
@mattverse I added |
ValarDragon
approved these changes
May 20, 2022
That's correct! |
|
This is super cool guys! |
johnletey
added a commit
to kyve-org/cosmos-sdk-old
that referenced
this pull request
Jun 13, 2022
johnletey
added a commit
to kyve-org/cosmos-sdk-old
that referenced
this pull request
Jun 15, 2022
9 tasks
johnletey
added a commit
to kyve-org/cosmos-sdk-old
that referenced
this pull request
Jun 27, 2022
* feat: custom proposal-based voting periods (#1) h/t osmosis-labs#239 * feat: expedited proposals (#2) * feat: expedited proposals h/t osmosis-labs#240 * fix: correctly generate random threshold params * fix: update randomised genesis state tests * feat: allow protocol stakers and delegators to vote (#3) * feat: expedited deposits (#4) h/t osmosis-labs#254 * fix: still include custom voting periods * fix: fallback to custom voting periods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom voting periods:
ProposalVotingPeriod[]ProposalVotingPeriodto the existingVotingParams(on-chain upgrade should be fine)Keeper#ActivateVotingPeriodto account for the new[]ProposalVotingPeriodNOTE: I did NOT add/implement
CustomVotingPeriodQuorumas I just didn't see that as necessary.ref: osmosis-labs/osmosis#1517