New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): unfork IAVL to v0.19.1 #313

Closed

p0mvn wants to merge 2 commits into osmosis-main from roman/unfork-iavl-main

Member

p0mvn commented Aug 18, 2022 •

edited

Closes: #XXX

What is the purpose of the change

Unforking IAVL to https://github.com/cosmos/iavl/releases/tag/v0.19.1

Related to: These changes are already upstreamed: cosmos#12626

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not applicable


          upgrade to v0.19.1

2ed9b5a

p0mvn force-pushed the roman/unfork-iavl-main branch from 63c21bf to 2ed9b5a Compare

August 18, 2022 03:09


          try v0.19.0

507b973

Member Author

p0mvn commented Aug 18, 2022

ref: osmosis-labs/osmosis#2369

Member Author

p0mvn commented Aug 18, 2022

Closing due to stability concerns

p0mvn closed this

tac0turtle commented Aug 22, 2022

Closing due to stability concerns

what stability concerns? the diff is mainly errors and a few other things. Do we need to revert upstream?

Member Author

p0mvn commented Sep 3, 2022

Closing due to stability concerns

what stability concerns? the diff is mainly errors and a few other things. Do we need to revert upstream?

Sorry for the late reply. Missed the notification.

I've run an Osmosis node with v0.19.1 cosmos IAVL for over 5 days without issues. However, I did not have telemetry setup to observe RAM and I/O usage.

I'm concerned because there are folks who have reported increased I/O usage with v0.19.1, the absence of which I haven't confirmed yet in Osmosis:
https://discord.com/channels/669268347736686612/680435043570941973/1009356834580217887

Additionally, I've observed data races in tests and some dependency issues. I haven't properly investigated them yet.

We decided to postpone this until after Osmosis v12, once more people try cosmos iavl v0.19.1, and we have the time to investigate the data races + telemetry data.

I know that @faddat is looking to unfork us sooner than that though. I have linked him to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment