Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Track rebase of our work onto cosmos-sdk v0.44.3 #43

Closed
wants to merge 23 commits into from

Conversation

sunnya97
Copy link

Tracking rebase process of cherry picking our commits on top of upstream/v0.44.3

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

* add minimum commission rate

* fixed DefaultMinCommissionRate comment

* Update x/staking/keeper/params.go

* Update x/staking/keeper/validator.go

* Update x/staking/keeper/validator_test.go

* Update x/staking/keeper/validator_test.go

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

* Update x/staking/keeper/validator_test.go

* fix lint

* make proto-all

* fix lint

* add powerreduction to params

* check protobuf breakage against osmo-v0.42.x instead of master

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@sunnya97 sunnya97 changed the title Add minimum commission rate to x/staking (#3) Track rebase of our work onto cosmos-sdk v0.44.3 Nov 17, 2021
@sunnya97 sunnya97 marked this pull request as draft November 17, 2021 05:04
ValarDragon and others added 8 commits November 17, 2021 01:12
* allocate multiple genesis coins on bank simulation

* fix test

* fix genesis

* fix test final

* increase default tx size

* Update x/bank/simulation/genesis.go

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

* fix test

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
* add mutable decimal methods

* fix root

* gofmt

* add Clone(), rm assignment quo

* add SetInt64

* fix SetInt64

* More mut speedups

Co-authored-by: ValarDragon <dojha12@gmail.com>
@sunnya97 sunnya97 force-pushed the sunny/rebase-v0.44.3 branch 2 times, most recently from 1844456 to 8e89646 Compare November 17, 2021 07:38
@sunnya97 sunnya97 changed the title Track rebase of our work onto cosmos-sdk v0.44.3 refactor: Track rebase of our work onto cosmos-sdk v0.44.3 Nov 17, 2021
sunnya97 and others added 8 commits November 17, 2021 12:06
* Significantly lower number of heap allocations that should be required by events

* Use EmitEvent instead of EmitEvents
…dule (#33)

* Add SenManyCoins method

* Add method SendCoinsFromModuleToManyAccounts in Bank module

* Lint
* Try to fix the mutex contention

* downstream copy my pr for logs in initgenesis

* CacheKVStore linear factor improvements

* Reset map size (extremely important for unfortunate access patterns)

* Comment out module.go test for init genesis, assume logger lines are safe
* filtered simulation fee tokens to only use sdk.DefaultBondDenom

* fixed simulation
@sunnya97
Copy link
Author

Can't cherry-pick ce6f14a cause ibc was moved to ibc-go. Remember to import the ante handler feature into osmosis repo.

@sunnya97 sunnya97 marked this pull request as ready for review November 18, 2021 09:31
@ValarDragon
Copy link
Member

ValarDragon commented Nov 19, 2021

This LGTM. We just need an issue to re-add #9 and figure out why it killed simulation on the 44 line. Going to prepare the Osmo branch for this.

@ValarDragon
Copy link
Member

LGTM!

I'm going to take this branch, rebase onto SDK v0.44.x, rename it, and then make it default.

@ValarDragon
Copy link
Member

Thanks for doing this! Moved to v0.44.3x-osmo-v5

@ValarDragon ValarDragon deleted the sunny/rebase-v0.44.3 branch November 19, 2021 06:24
@ValarDragon ValarDragon restored the sunny/rebase-v0.44.3 branch November 19, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants