Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move encoding files to its own module/folder #2

Open
ValarDragon opened this issue Jan 12, 2022 · 2 comments
Open

Move encoding files to its own module/folder #2

ValarDragon opened this issue Jan 12, 2022 · 2 comments

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 12, 2022 •
edited
Loading

The existing IAVL code is very poorly structured, getting more files out of the root directory will only help

We should move encoding and encoding_test to a single encoding folder. We would have to make every function in encoding.go exported which is fine.

This has no external API breaks, as all these functions are internal only.
@ValarDragon ValarDragon changed the title Move encoding files to its own package Move encoding files to its own module/folder Jan 12, 2022
@tac0turtle
Copy link

this should be moved to internal/encoding. This makes it public to the repo and private when used by others. Easier to fix The API this way.

@tac0turtle
Copy link

cosmos#460 here is the pr for this.

@faddat faddat mentioned this issue Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @tac0turtle