Cheaper IBC deposit fees #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for epic-hugle-6681dc ready! 🔨 Explore the source changes: b826e1d 🔍 Inspect the deploy log: https://app.netlify.com/sites/epic-hugle-6681dc/deploys/619f5355b965960007fddc9b 😎 Browse the preview: https://deploy-preview-103--epic-hugle-6681dc.netlify.app |
|
err, how were these gas constants obtained? They are oddly, vastly different |
|
Os Secret from having a lower gas setup, on other chains from observations. Why was 500k decided for other chains? Why is it 1.35M on Osmosis? |
|
Oh, odd. I didn't notice it was 1.35M vs 500k earlier, my bad! |
ValarDragon
reviewed
Nov 25, 2021
src/stores/root.ts
Outdated
Comment on lines
106
to
108
| } else if (chainInfo.chainId.startsWith('columbus-') || chainInfo.chainId.startsWith('cosmoshub-')) { | ||
| gas = 100_000; | ||
| } |
There was a problem hiding this comment.
Can we revert this clause? Then looks good to merge to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced fees on IBC Deposit from Secret, Cosmos & Terra by setting more appropriate gas limits.