-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding upcoming gauges query (backport #1195) #1257
Conversation
* Add queries for getting Upcoming gauges by denom * rudimentary tests for denomquery * Update proto/osmosis/incentives/query.proto Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * removed mytestnet * fixed query tests * fixed query tests * Update proto/osmosis/incentives/query.proto pagination number Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/incentives/keeper/grpc_query.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * implemented feedback * amended minor bug with prefixStore * investigating BeginDistribution issues * investigating grpc_query_test.go * Fix grpc query test * fixed grpc tests, added nil checks for grpc query, removed long for query.go * additional grpcquery fixes (double if removed) * liveliness error fix * gofmt grpc_query_test.go * liveliness test fixes * liveliness test fixes Co-authored-by: Xiangan He <xiangan@polychain.capital> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu> (cherry picked from commit eb39af7) # Conflicts: # docs/core/proto-docs.md # go.mod # go.sum # proto/osmosis/gamm/v1beta1/query.proto # x/gamm/types/query.pb.go # x/incentives/client/cli/query.go # x/incentives/keeper/grpc_query.go
Codecov Report
@@ Coverage Diff @@
## v7.x #1257 +/- ##
==========================================
- Coverage 20.86% 20.63% -0.23%
==========================================
Files 199 199
Lines 25416 25803 +387
==========================================
+ Hits 5303 5325 +22
- Misses 19150 19509 +359
- Partials 963 969 +6
Continue to review full report at Codecov.
|
@xBalbinus can you address the conflicts here and we can get this backported :) |
hmm! fixed the weird conflicts, I think - let me know if this is good or if it didn't work. |
err, I'm pretty sure that last commit didn't fix the conflicts. It looks like maybe main got merged in? I suggest we undo that last commit |
Oh shoot okay, let’s undo that…
…On Mon, Apr 18, 2022 at 11:05 AM Dev Ojha ***@***.***> wrote:
err, I'm pretty sure that last commit didn't fix the conflicts. It looks
like maybe main got merged in?
I suggest we undo that last commit
—
Reply to this email directly, view it on GitHub
<#1257 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASH4FPU7HGLWNCCVNBKK66DVFV22JANCNFSM5TPMSMVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This is an automatic backport of pull request #1195 done by Mergify.
Cherry-pick of eb39af7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com