Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding upcoming gauges query (backport #1195) #1257

Merged
merged 5 commits into from
Apr 18, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 15, 2022

This is an automatic backport of pull request #1195 done by Mergify.
Cherry-pick of eb39af7 has failed:

On branch mergify/bp/v7.x/pr-1195
Your branch is up to date with 'origin/v7.x'.

You are currently cherry-picking commit eb39af7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   proto/osmosis/incentives/query.proto
	modified:   x/incentives/client/cli/cli_test.go
	modified:   x/incentives/keeper/grpc_query_test.go
	modified:   x/incentives/types/query.pb.go
	modified:   x/incentives/types/query.pb.gw.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/core/proto-docs.md
	both modified:   go.mod
	both modified:   go.sum
	both modified:   proto/osmosis/gamm/v1beta1/query.proto
	both modified:   x/gamm/types/query.pb.go
	both modified:   x/incentives/client/cli/query.go
	both modified:   x/incentives/keeper/grpc_query.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add queries for getting Upcoming gauges by denom

* rudimentary tests for denomquery

* Update proto/osmosis/incentives/query.proto

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

* removed mytestnet

* fixed query tests

* fixed query tests

* Update proto/osmosis/incentives/query.proto pagination number

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* Update x/incentives/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* implemented feedback

* amended minor bug with prefixStore

* investigating BeginDistribution issues

* investigating grpc_query_test.go

* Fix grpc query test

* fixed grpc tests, added nil checks for grpc query, removed long for query.go

* additional grpcquery fixes (double if removed)

* liveliness error fix

* gofmt grpc_query_test.go

* liveliness test fixes

* liveliness test fixes

Co-authored-by: Xiangan He <xiangan@polychain.capital>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
(cherry picked from commit eb39af7)

# Conflicts:
#	docs/core/proto-docs.md
#	go.mod
#	go.sum
#	proto/osmosis/gamm/v1beta1/query.proto
#	x/gamm/types/query.pb.go
#	x/incentives/client/cli/query.go
#	x/incentives/keeper/grpc_query.go
@mergify mergify bot added the conflicts label Apr 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #1257 (3cfd49b) into v7.x (523ed35) will decrease coverage by 0.22%.
The diff coverage is 3.00%.

@@            Coverage Diff             @@
##             v7.x    #1257      +/-   ##
==========================================
- Coverage   20.86%   20.63%   -0.23%     
==========================================
  Files         199      199              
  Lines       25416    25803     +387     
==========================================
+ Hits         5303     5325      +22     
- Misses      19150    19509     +359     
- Partials      963      969       +6     
Impacted Files Coverage Δ
x/incentives/client/cli/query.go 0.00% <0.00%> (ø)
x/incentives/keeper/query.go 0.00% <ø> (ø)
x/incentives/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/incentives/types/query.pb.go 0.81% <0.63%> (-0.03%) ⬇️
x/incentives/keeper/grpc_query.go 63.80% <50.00%> (+8.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523ed35...3cfd49b. Read the comment docs.

@alexanderbez
Copy link
Contributor

@xBalbinus can you address the conflicts here and we can get this backported :)

@xBalbinus
Copy link
Contributor

hmm! fixed the weird conflicts, I think - let me know if this is good or if it didn't work.

@ValarDragon
Copy link
Member

err, I'm pretty sure that last commit didn't fix the conflicts. It looks like maybe main got merged in?

I suggest we undo that last commit

@xBalbinus
Copy link
Contributor

xBalbinus commented Apr 18, 2022 via email

@ValarDragon ValarDragon merged commit be00a48 into v7.x Apr 18, 2022
@ValarDragon ValarDragon deleted the mergify/bp/v7.x/pr-1195 branch April 18, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants