Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osmolbp CLI client bootstrapping. #1549

Merged
merged 15 commits into from
May 20, 2022
Merged

Osmolbp CLI client bootstrapping. #1549

merged 15 commits into from
May 20, 2022

Conversation

dayakarreddyn
Copy link

What is the purpose of the change

This PR bootstraps cli client functionality.

Brief Changelog

  • Added CLI client

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@robert-zaremba robert-zaremba self-requested a review May 20, 2022 10:40
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. Left few comments. There are conflicts to solve.

x/osmolbp/keeper/query_server.go Outdated Show resolved Hide resolved
x/osmolbp/keeper/store.go Outdated Show resolved Hide resolved
x/osmolbp/client/cli/flags.go Show resolved Hide resolved
@ValarDragon
Copy link
Member

Why did every proto file change? Was there some change to proto compilation tooling merged?

@ValarDragon
Copy link
Member

Oh this is being merged to the LBP branch. Feel free to squash merge Robert

@robert-zaremba
Copy link
Contributor

yes, at the end I will regenerate the files anyway

@robert-zaremba robert-zaremba merged commit bee913d into osmosis-labs:osmolbp May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants