-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
launchpad/cli: sale and user position queries & msg validation fixes #1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving. let's remove duplicated examples.
@@ -184,6 +184,7 @@ func orderBeginBlockers() []string { | |||
bech32ibctypes.ModuleName, | |||
txfeestypes.ModuleName, | |||
wasm.ModuleName, | |||
launchpad.ModuleName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
if _, err := sdk.AccAddressFromBech32(msg.Sender); err != nil { | ||
return errors.ErrInvalidRequest.Wrapf("Invalid sender address (%s)", msg.Sender) | ||
} | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, thanks for updating this!
x/launchpad/client/cli/tx.go
Outdated
Long: strings.TrimSpace( | ||
fmt.Sprintf(`Finalize a launchpad sale : | ||
Example: | ||
$ %s finalize --sale-id=sale-id [flags] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ %s finalize --sale-id=sale-id [flags] |
x/launchpad/client/cli/tx.go
Outdated
"treasury": "osmo1r85gjuck87f9hw7l2c30w3zh696xrq0lus0kq6" | ||
"start-time": "2022-06-02T11:18:11.000Z", | ||
"duration": "432000s", | ||
"treasury": "osmo16phc92xevvcvswdew....cr46tn8pneshtsl8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why adding the dots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dayakarreddyn updated it .. may be for not using any full address in example
but i think it's okay even we use a valid address
should we use valid address ?
No description provided.