New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL]: CL Incentives Sumtree #3886
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
Changes to the app folder
C:CLI
C:x/concentrated-liquidity
C:x/lockup
C:x/swaprouter
labels
Dec 30, 2022
AlpinYukseloglu
changed the title
Alpo/cl incentives
[CL]: Minimum-uptime CL Incentives
Dec 30, 2022
AlpinYukseloglu
changed the base branch from
main
to
adam/cl-merge-main-addition
December 30, 2022 12:37
AlpinYukseloglu
changed the base branch from
adam/cl-merge-main-addition
to
main
December 30, 2022 12:40
AlpinYukseloglu
changed the title
[CL]: Minimum-uptime CL Incentives
[CL]: CL Incentives Sumtree
Dec 30, 2022
AlpinYukseloglu
changed the base branch from
main
to
concentrated-liquidity-main
December 31, 2022 10:36
AlpinYukseloglu
changed the base branch from
concentrated-liquidity-main
to
main
December 31, 2022 10:37
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewer: Large part of diff is unmerged general CL changes
What is the purpose of the change
This PR implements sumtree usage in CL for incentives. Our original design for CL incentives required tracking a second sum in our sumtree. This is simple to add but left out of this PR for now since there is a good chance we can handle that logic with a CL-side accumulator + existing sumtree logic
Brief Changelog
sdk.Dec
instead ofsdk.Int
Testing and Verifying
All new position-related sumtree logic is heavily tested in
position_test.go
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (no)