Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL]: CL Incentives Sumtree #3886

Closed
wants to merge 21 commits into from
Closed

[CL]: CL Incentives Sumtree #3886

wants to merge 21 commits into from

Conversation

AlpinYukseloglu
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu commented Dec 30, 2022

Note to reviewer: Large part of diff is unmerged general CL changes

What is the purpose of the change

This PR implements sumtree usage in CL for incentives. Our original design for CL incentives required tracking a second sum in our sumtree. This is simple to add but left out of this PR for now since there is a good chance we can handle that logic with a CL-side accumulator + existing sumtree logic

Brief Changelog

  • Change sumtree to accumulate sdk.Dec instead of sdk.Int
  • Populate a sumtree tracking position join times for each pool every time a position is updated
  • Thoroughly fuzz test new sumtree logic

Testing and Verifying

All new position-related sumtree logic is heavily tested in position_test.go

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
  • How is the feature or change documented? (not documented)

@AlpinYukseloglu AlpinYukseloglu changed the title Alpo/cl incentives [CL]: Minimum-uptime CL Incentives Dec 30, 2022
@github-actions github-actions bot removed the C:CLI label Dec 30, 2022
@AlpinYukseloglu AlpinYukseloglu changed the base branch from main to adam/cl-merge-main-addition December 30, 2022 12:37
@AlpinYukseloglu AlpinYukseloglu changed the base branch from adam/cl-merge-main-addition to main December 30, 2022 12:40
@AlpinYukseloglu AlpinYukseloglu changed the title [CL]: Minimum-uptime CL Incentives [CL]: CL Incentives Sumtree Dec 30, 2022
@AlpinYukseloglu AlpinYukseloglu changed the base branch from main to concentrated-liquidity-main December 31, 2022 10:36
@AlpinYukseloglu AlpinYukseloglu changed the base branch from concentrated-liquidity-main to main December 31, 2022 10:37
@p0mvn p0mvn mentioned this pull request Jan 12, 2023
32 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jan 15, 2023
@github-actions github-actions bot closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants