Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sdk fork with the change for correct block time in historical queries #5134

Merged
merged 2 commits into from
May 9, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 9, 2023

Closes: #XXX

What is the purpose of the change

Backporting: osmosis-labs/cosmos-sdk#441 to v15.x

This is required for correct historical TWAP queries.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn changed the title feat: update sdk fork with the change for correct block time in histo… feat: update sdk fork with the change for correct block time in historical queries May 9, 2023
@p0mvn p0mvn marked this pull request as ready for review May 9, 2023 05:05
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CI check passes (looks like it failed on something unrelated)

@p0mvn p0mvn merged commit c38bd33 into v15.x May 9, 2023
1 check passed
@p0mvn p0mvn deleted the roman/v15-sdk-fork branch May 9, 2023 14:10
@p0mvn
Copy link
Member Author

p0mvn commented May 9, 2023

LGTM after CI check passes (looks like it failed on something unrelated)

It's the broken state compatibility check which is unrelated

@github-actions github-actions bot mentioned this pull request Jan 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants