CLI: Query pools by coin denom #6766

DongLieu · 2023-10-26T05:55:20Z

Closes: #6712

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes?
Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

Specification (x/{module}/README.md)
Osmosis documentation site
Code comments?
N/A

DongLieu · 2023-10-26T06:00:52Z

DongLieu · 2023-10-26T06:01:58Z

DongLieu · 2023-10-26T06:09:20Z

I have 6 pools in which:
+ 1. stake-uosmo
+ 2. atom-stake
+ 3.uosmo-atom
+ 4. stake-uosmo
+ 5. atom-stake
+ 6.uosmo-atom
Query by denom "stake":
+ 1. stake-uosmo
+ 2. atom-stake
+ 4. stake-uosmo
+ 5. atom-stake

pysel

hey @DongLieu! Thank you for tackling this issue. And thanks for attaching logs to the PR.

Could you please also include a unit test for this query?

x/poolmanager/client/query_proto_wrap.go

x/poolmanager/router.go

mattverse

Nice! Left some comments, please take a look!

proto/osmosis/poolmanager/v1beta1/query.proto

x/poolmanager/router.go

Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

mattverse · 2023-10-27T05:27:01Z

@DongLieu Can we also add changelog for this?

DongLieu · 2023-10-27T05:34:11Z

Thanks @mattverse and @pysel for your review.
Ok @mattverse. I add changelog now

DongLieu · 2023-11-01T17:05:34Z

Hey, to make it easier for the following issues, can you add me to the repo?

DongLieu · 2023-11-01T17:08:14Z

I mean I can't push my branch to osmosis

pysel · 2023-11-01T20:53:18Z

Hey, to make it easier for the following issues, can you add me to the repo?

I cannot do that unfortunately. For the sake of this PR, could you please run make proto-all and push changes to your local branch? thanks!

mattverse · 2023-11-02T07:21:15Z

If it continues failing, happy to merge it and then run make proto-all after wards, no worries

DongLieu · 2023-11-02T07:26:54Z

I tried pulling main from osmosis and merging, then running 'make proto-all' but no change. So I thought it was my laptop's fault, but thanks to @hieuvubk help, it's still the same.

x/poolmanager/router.go

DongLieu · 2023-11-05T09:52:05Z

I added test for func @mattverse

mattverse

LGTM

@DongLieu Would you be able to add a case that includes CL pools? After that I think we should be good to merge

x/poolmanager/router_test.go

mattverse · 2023-11-07T04:34:11Z

x/poolmanager/router_test.go

+			expectedNumPools: 0,
+		},
+		"Many pools": {
+			poolType: []types.PoolType{types.Balancer, types.Balancer, types.Balancer, types.Balancer},


Can we also test with CL?

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

DongLieu · 2023-11-07T08:11:13Z

I added. Is it exactly what you wanted? @mattverse

mattverse · 2023-11-09T03:50:01Z

@DongLieu awesome thanks!

Will leave this PR open incase anyone wants to give it extra review, will merge this by EOW o.w

Has been addresed

* Add Cli query pools by denom * revert * minor * minor * Update x/poolmanager/client/query_proto_wrap.go Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> * Update x/poolmanager/client/query_proto_wrap.go Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> * Update x/poolmanager/router.go Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Update x/poolmanager/router.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Update x/poolmanager/router.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Update x/poolmanager/router.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * minor and lint * Use dynamic slice instead of Allocate the slice * changelog * make proto-gen * lint proto * add test * Update x/poolmanager/router_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Update x/poolmanager/router_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * make proto-all * use a few poolType Concentrated --------- Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com>

DongLieu added 5 commits October 24, 2023 11:16

Add Cli query pools by denom

eb4cebc

revert

a9df2c7

minor

fc7cd18

Merge branch 'main' into dong/list-pools-by-denom

a7601dc

minor

59b9dfd

DongLieu requested review from czarcas7ic, p0mvn, mattverse and AlpinYukseloglu as code owners October 26, 2023 05:55

github-actions bot added C:CLI T:build C:x/poolmanager labels Oct 26, 2023

pysel previously requested changes Oct 26, 2023

View reviewed changes

mattverse reviewed Oct 27, 2023

View reviewed changes

DongLieu and others added 9 commits October 27, 2023 12:02

Update x/poolmanager/client/query_proto_wrap.go

60cda3a

Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>

Update x/poolmanager/client/query_proto_wrap.go

767245f

Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>

Update x/poolmanager/router.go

c7e97b4

Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>

Update proto/osmosis/poolmanager/v1beta1/query.proto

b6a1548

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Update x/poolmanager/router.go

db8ab86

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Update proto/osmosis/poolmanager/v1beta1/query.proto

a676097

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Update x/poolmanager/router.go

d27e288

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Update x/poolmanager/router.go

ebda3b4

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

minor and lint

49dcac4

mattverse added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Oct 27, 2023

Use dynamic slice instead of Allocate the slice

0f5179c

lint proto

e22a244

Merge branch 'main' into dong/list-pools-by-denom

045fcac

mattverse reviewed Nov 3, 2023

View reviewed changes

x/poolmanager/router.go Show resolved Hide resolved

DongLieu added 2 commits November 5, 2023 15:37

Merge branch 'main' into dong/list-pools-by-denom

3903673

add test

182a261

mattverse approved these changes Nov 7, 2023

View reviewed changes

DongLieu and others added 5 commits November 7, 2023 14:39

Update x/poolmanager/router_test.go

18022fd

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Update x/poolmanager/router_test.go

dbaee05

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

merge main and fix config

d8837d3

make proto-all

51d4e04

use a few poolType Concentrated

cdccac1

Merge branch 'main' into dong/list-pools-by-denom

b839255

DongLieu added 2 commits November 12, 2023 12:53

Merge branch 'main' into dong/list-pools-by-denom

42e668b

Merge branch 'main' into dong/list-pools-by-denom

7fc45e0

mattverse requested a review from pysel November 15, 2023 10:30

mattverse merged commit 6e876a6 into osmosis-labs:main Nov 15, 2023
1 check passed

levisyin mentioned this pull request Nov 16, 2023

refactor: improve ListPoolsByDenom filter logic #6884

Merged

github-actions bot mentioned this pull request Mar 15, 2024

Broken Links Detected #7752

Closed

github-actions bot mentioned this pull request Apr 15, 2024

Broken Links Detected #8046

Closed

github-actions bot mentioned this pull request May 1, 2024

Broken Links Detected #8183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI: Query pools by coin denom #6766

CLI: Query pools by coin denom #6766

DongLieu commented Oct 26, 2023

DongLieu commented Oct 26, 2023

DongLieu commented Oct 26, 2023

DongLieu commented Oct 26, 2023

pysel left a comment

mattverse left a comment

mattverse commented Oct 27, 2023

DongLieu commented Oct 27, 2023

DongLieu commented Nov 1, 2023

DongLieu commented Nov 1, 2023

pysel commented Nov 1, 2023

mattverse commented Nov 2, 2023

DongLieu commented Nov 2, 2023 •

edited

Loading

DongLieu commented Nov 5, 2023

mattverse left a comment

mattverse Nov 7, 2023

DongLieu commented Nov 7, 2023

mattverse commented Nov 9, 2023

CLI: Query pools by coin denom #6766

CLI: Query pools by coin denom #6766

Conversation

DongLieu commented Oct 26, 2023

What is the purpose of the change

Testing and Verifying

Documentation and Release Note

DongLieu commented Oct 26, 2023

DongLieu commented Oct 26, 2023

DongLieu commented Oct 26, 2023

pysel left a comment

Choose a reason for hiding this comment

mattverse left a comment

Choose a reason for hiding this comment

mattverse commented Oct 27, 2023

DongLieu commented Oct 27, 2023

DongLieu commented Nov 1, 2023

DongLieu commented Nov 1, 2023

pysel commented Nov 1, 2023

mattverse commented Nov 2, 2023

DongLieu commented Nov 2, 2023 • edited Loading

DongLieu commented Nov 5, 2023

mattverse left a comment

Choose a reason for hiding this comment

mattverse Nov 7, 2023

Choose a reason for hiding this comment

DongLieu commented Nov 7, 2023

mattverse commented Nov 9, 2023

DongLieu commented Nov 2, 2023 •

edited

Loading