Add maximum pool ID #7203
Merged
Add maximum pool ID #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
czarcas7ic,
p0mvn,
mattverse and
AlpinYukseloglu
as code owners
AlpinYukseloglu
approved these changes
Dec 24, 2023
czarcas7ic
approved these changes
Dec 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes a maximum pool ID of 100 billion - 1
This lets us make allocations for certain keys more efficient, that legacy use string formatting instead of uint64 representation.
At $1 to create a pool, this costs too much to ever be an issue. Let alone the $10 to $100 range governance currently seems to be in the mind of.