Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking a tab? #21

Open
jtagcat opened this issue Jan 3, 2021 · 6 comments
Open

Tracking a tab? #21

jtagcat opened this issue Jan 3, 2021 · 6 comments
Labels
interface involves making new synthetic files / changes to synth file reporting

Comments

@jtagcat
Copy link

jtagcat commented Jan 3, 2021

#16 after you open a tab, or do something with it, getting a tab ID or something would be nice, as you could be sure multiple commands get directed at the same tab (even if you have duplicate tabs).

@osnr
Copy link
Owner

osnr commented Jan 3, 2021

Yeah. I'm not sure how exactly we could do that with the current create file setup (you read it right afterward?); might need to change approach.

Maybe you can make a tab file or folder in a create directory and then read it to get the ID, or it immediately turns into a symlink to the new tab, or something. Or there's a synthetic file ./create which is actually an executable you can run that outputs the tab ID.

@JinchengWang
Copy link

How about a last_created_tab file containing the last created tab id?

@jtagcat
Copy link
Author

jtagcat commented Jan 3, 2021

Reading right after, and last created both have the problem of assuming non-async. While almost everything we are talking here are made to be async. You can't assume you're the only process interacting with tabs.

@osnr
Copy link
Owner

osnr commented Jan 3, 2021

We could make it so that if you read it right afterward from the same file handle, you get the result (each caller would open it with a different handle). I don't know if that would be usable from normal command line tools, though.

btw, there are also a bunch of options that it would be nice to support if we end up rethinking the way create works

@JinchengWang
Copy link

BTW it would be nice to support windows.create as well. Similar user interfaces might work in both cases.

@jtagcat
Copy link
Author

jtagcat commented Jan 3, 2021

I know it might be a bad idea, a fs is nice and everything.

..but what about exposing the browser with solid commands first, and then give the ability to mount it?

It seems counterproductive to do it the other way around.

@osnr osnr added the interface involves making new synthetic files / changes to synth file reporting label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface involves making new synthetic files / changes to synth file reporting
Projects
None yet
Development

No branches or pull requests

3 participants