Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring mount point instead of hardcoded "mnt" directory #37

Closed
buckley-w-david opened this issue Jan 4, 2021 · 1 comment · Fixed by #38
Closed

Configuring mount point instead of hardcoded "mnt" directory #37

buckley-w-david opened this issue Jan 4, 2021 · 1 comment · Fixed by #38

Comments

@buckley-w-david
Copy link
Contributor

buckley-w-david commented Jan 4, 2021 •
edited
Loading

Checking to see if there is any interest from you (or others) for configuring the mount point instead of it being tied to a hardcoded mnt directory.

I've added a check for an environment variable TABFS_MOUNT_DIR to my fork, mostly curious if you'd like a PR for it.

You can check the diff here: master...buckley-w-david:master
@osnr
Copy link
Owner

osnr commented Jan 4, 2021

Hi! Yes, this is great -- would definitely accept this PR. #31 shows that other people seem to want it, too.

@buckley-w-david buckley-w-david mentioned this issue Jan 4, 2021
Merged
@osnr osnr closed this as completed in #38 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use environment varaible to configure mount location buckley-w-david/TabFS
2 participants
@osnr @buckley-w-david