Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge logging options with POLAR_LOG. #1252

Merged
merged 4 commits into from Oct 5, 2021
Merged

Merge logging options with POLAR_LOG. #1252

merged 4 commits into from Oct 5, 2021

Conversation

samscott89
Copy link
Member

@samscott89 samscott89 commented Oct 5, 2021 •
edited

PR checklist:

  • Added changelog entry.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

gkaemmer
gkaemmer approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@gkaemmer gkaemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was going to look into using tracing::debug!(...) but this is actually a much simpler change.

@samscott89 samscott89 marked this pull request as ready for review October 5, 2021 19:36
samscott89
samscott89 commented Oct 5, 2021
View reviewed changes
polar-core/src/vm.rs Outdated Show resolved Hide resolved
@samscott89 samscott89 merged commit 6cb60c7 into main Oct 5, 2021
@samscott89 samscott89 deleted the sam/slighty-smarter-logging branch October 5, 2021 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkaemmer gkaemmer gkaemmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samscott89 @gkaemmer