Update missing actor block error message to include suggested remediation #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add integration test to check that we provide a recommended fix in the scenario where a policy contains resource blocks without corresponding actor block Updating multi-line error message indentation to match others
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
gkaemmer
reviewed
Oct 6, 2021
…ror-msg' into patrickod/missing-actor-block-error-msg
gkaemmer
approved these changes
Oct 6, 2021
| @@ -1576,6 +1576,32 @@ fn test_unknown_specializer_warning() -> TestResult { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_missing_actor_warning() -> TestResult { | |||
There was a problem hiding this comment.
Perhaps test_missing_actor_hint?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist: