Add PolarClass implementation for uuid::Uuid #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
samscott89
previously requested changes
Nov 29, 2020
Co-authored-by: Sam Scott <sam.scott89@gmail.com>
- Rely on default implementation for get_polar_class on Uuid PolarClass trait impl - Format get_polar_class_builder with rustfmt
gj
reviewed
Nov 30, 2020
- Add diesel mod to provide impl of PolarClass for Uuid - Rename uuid crate to uuid_v06 - Rename uuid feature to uuid_v06 - Rename extra feature group to diesel - Update PolarClass impl for Uuid to use full path for foreign types
We can consider adding a "diesel" group if diesel requires additional PolarClass impls, but for now I think we're good with a single feature flag for a single impl.
gj
approved these changes
Dec 1, 2020
|
Thanks again @johnhalbert ! Credited you in the changelog 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation for foreign type uuid::Uuid. This is behind a feature gate
uuid. Tests have been added to the/languages/rust/oso/tests/test_polar_rust.rssuite. Tests require runningcargo testwith--features uuidoption. (e.g.$ cargo test --features uuid)Note:
Cargo.tomlin/languages/rust/oso/specifies version0.6.5ofuuid. The latest version is0.8.1at the time of writing, but the version currently used in diesel orm is0.6.5. Because of the popularity ofdiesel, and the likelihood of persisting UUID's to the database in a web application context, I used0.6.5for compatibility withdiesel.PR checklist: