-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ability to set context deadline for GRPC calls #18
Comments
Hey, this makes sense to me. For me personally it makes more sense to focus first on supporting transactions. But if you want to enable context deadlines, feel free to submit a PR. I would just ask you to
Thanks! |
I agree I'd probably want to see transaction support first as well but I'll give this a shot. |
@emhagman I sometimes get the error
back from Dgraph. So a context deadline is already set but not explicitly. This seems to be a performance issue and goes away when I reset Dgraph by deleting all data. So setting this explicitly from ExDgraph seems to be a very good idea 😉 |
See #24 |
See:
https://github.com/tony612/grpc-elixir/blob/b635aff233e8db173557e9eca414bc9d640e71d7/test/grpc/integration/stub_test.exs
Also see:
https://discuss.dgraph.io/t/dgraph-java-client-setting-deadlines-per-call/3056
And also why we should be able to pass it in:
https://grpc.io/blog/deadlines
The text was updated successfully, but these errors were encountered: