Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ability to set context deadline for GRPC calls #18

Closed
emhagman opened this issue Oct 1, 2018 · 4 comments
Closed

Allow ability to set context deadline for GRPC calls #18

emhagman opened this issue Oct 1, 2018 · 4 comments

Comments

@emhagman
Copy link
Contributor

emhagman commented Oct 1, 2018

@ospaarmann
Copy link
Owner

Hey,

this makes sense to me. For me personally it makes more sense to focus first on supporting transactions. But if you want to enable context deadlines, feel free to submit a PR. I would just ask you to

  • outline here how you plan to do it
  • make it configurable and make sure, that the naming is not confusing (we already have :timeout which holds the value for the connection timeout)

Thanks!
Ole

@emhagman
Copy link
Contributor Author

I agree I'd probably want to see transaction support first as well but I'll give this a shot.

@ospaarmann
Copy link
Owner

@emhagman I sometimes get the error

{:error, [code: 2, message: "While proposing: context deadline exceeded"]}

back from Dgraph. So a context deadline is already set but not explicitly. This seems to be a performance issue and goes away when I reset Dgraph by deleting all data. So setting this explicitly from ExDgraph seems to be a very good idea 😉

@emhagman
Copy link
Contributor Author

See #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants