Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the GRPC deadline and DBConnection checkout timeout to use :timeout #24

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

emhagman
Copy link
Contributor

@emhagman emhagman commented Mar 27, 2019

@ospaarmann knows about this. We were not setting the GRPC deadline so a query that took too long past the 15 second DBConnection timeout would continue to run on Dgraph. Separately, DBConnection checkout was never being set so the connection would always close after 15 seconds but would retry the query up until the :timeout value set. This PR fixes both of those issues.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 148

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 68.936%

Totals Coverage Status
Change from base Build 137: 0.4%
Covered Lines: 162
Relevant Lines: 235

💛 - Coveralls

@ospaarmann ospaarmann merged commit f6df905 into ospaarmann:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants