Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print and Copy and CSV of Built Table are not correct #629

Closed
martinholmer opened this issue Aug 18, 2017 · 1 comment
Closed

Print and Copy and CSV of Built Table are not correct #629

martinholmer opened this issue Aug 18, 2017 · 1 comment
Labels
Milestone

Comments

@martinholmer
Copy link
Contributor

martinholmer commented Aug 18, 2017

I ran current-law policy (that is, no changes on the TaxBrain GUI input page) through TaxBrain and on the Static Results page I built a table with these specifications:

screen shot 2017-08-18 at 2 50 58 pm

The built table on the Static Results page looks like this:

screen shot 2017-08-18 at 2 52 07 pm

So far, so good.

But when I print this table, the printed output is fine except for the fact that a second blank page was printed. This bug was originally reported on April 13th in issue #534.

When I copy this table, here is what I get when I paste the copied table here:

                                TOTAL LIABILITIES BY CALENDAR YEAR (CHANGE)                            
	Returns	AGI	Taxable Income	Individual Income Tax Liabilities	Payroll Tax Liablities
	Thousands	Billions	Billions	Billions	Billions
Less than 10	23,157	89.6	3.3	-8.2	12.3
10-20	24,467	237.4	35.7	-33.6	33.5
20-30	18,943	321.4	96.9	-16.6	42.4
30-40	16,372	423.7	183.5	2.7	52.9
40-50	13,283	484.3	261.8	22.2	58.0
50-75	22,758	1,216.4	752.8	88.8	136.1
75-100	13,548	1,070.8	743.8	102.0	120.7
100-200	23,024	2,964.9	2,228.5	367.0	359.9
200-500	7,922	2,148.3	1,755.4	409.2	200.7
500-1000	1,179	772.0	691.3	202.5	38.1
1000+	636	1,867.9	1,748.9	564.7	32.9
All	170,055	11,445.6	8,502.5	1,700.2	1,089.9
Source: http://www.ospc.org/taxbrain/15852/					

Notice that the row and column labels are the same as the printed table and the numbers in the table cells are the same as the printed table, but the title is different and incorrect. It was reported on April 13th in issue #534 that the copied table had no title and a title has been added subsequently. But the title is incorrect. Why not use the same title as is showing on Static Results page (which is the same as what it printed out)?

The title should be this:

BASE PLAN TAX VARS, WEIGHTED TOTAL BY EXPANDED INCOME BIN (2017)

rather than this

TOTAL LIABILITIES BY CALENDAR YEAR (CHANGE)

Also, note that when clicking on the CSV button and bringing the downloaded .csv file into a spreadsheet, the new title is the same (incorrect title) as in the Copy. Now the downloaded file has a meaningful filename 15852_2017_diagnostic_currentlaw_bins.csv, which is a big improvement from last April.

Can we fix the new title used in the Copy and CSV actions?
And can we also fix the print to eliminate the blank page at the end?

@MattHJensen @brittainhard @GoFroggyRun

P.S. I would presume that clicking on the Excel button will download a file that has the same incorrect title, but I can't test that because I don't have Excel on my computer

@martinholmer martinholmer changed the title Print and Copy of Built Table are not correct Print and Copy and CSV of Built Table are not correct Aug 18, 2017
@martinholmer martinholmer added this to the 1.0.2 Release milestone Aug 18, 2017
@martinholmer
Copy link
Contributor Author

Issue #629 is resolved in TaxBrain 1.0.3. @GoFroggyRun, thanks for your work on pull request #675.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants